You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/02/28 01:21:44 UTC
Review Request 70069: Improved `ResourceQuantities` test's
readability.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70069/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Improved `ResourceQuantities` test's readability.
Diffs
-----
src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
Diff: https://reviews.apache.org/r/70069/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70069: Improved `ResourceQuantities` test's
readability.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70069/#review213600
-----------------------------------------------------------
Ship it!
src/tests/resource_quantities_tests.cpp
Lines 46 (patched)
<https://reviews.apache.org/r/70069/#comment299579>
Maybe?
const auto& q
auto&&
- Benjamin Mahler
On Feb. 28, 2019, 1:21 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70069/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2019, 1:21 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved `ResourceQuantities` test's readability.
>
>
> Diffs
> -----
>
> src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
>
>
> Diff: https://reviews.apache.org/r/70069/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>