You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wankunde (via GitHub)" <gi...@apache.org> on 2023/12/04 01:29:46 UTC
Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Make sure the cast expression is date type when unwrap timestamp type to date type [spark]
wankunde commented on PR #44134:
URL: https://github.com/apache/spark/pull/44134#issuecomment-1837699068
> Hi, @wankunde .
>
> * The follow-up should not reuse the original PR title. Please use a proper PR title for your code itself.
>
> ```
> - Cast(fromExp, _, timeZoneId, evalMode), ts @ Literal(value, _))
> + Cast(fromExp: DateType, _, timeZoneId, evalMode), ts @ Literal(value, _))
> ```
>
> * Could you re-trigger the CIs or provide the CI link?
Thanks for your remind, update the PR title and re-trigger the CI, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org