You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Rick McGuire <ri...@gmail.com> on 2010/01/22 19:14:44 UTC
OpenJPA2 build breakage in trunk
There's a nasty build breakage in trunk caused by switching to the
latest jpa 2.0 spec jar from the one used for the OpenJPA milestone
release. This change requires some code changes to the Geronimo code
because some methods were removed and some classes were moved to
different package locations. I've got the code compiling cleanly with
the new spec jar, but that just moved things on to another problem.
The next problem to arise came from the mismatch between the OpenJPA
2.0.0-M3 release and this spec jar. The M3 OpenJPA code still had
references to classes in the old package locations, so we ended up with
ClassNotFoundExceptions while trying to build. Ok, this should be a
simple fix...it just requires changing the OpenJPA version to the
2.0.0-SNAPSHOT level. And here is where things start to get nasty. The
current trunk code for OpenJPA no longer builds the OpenJPA jars as
bundles. This issue was already noticed by the Aries folks and a Jira
was opened on it:
https://issues.apache.org/jira/browse/OPENJPA-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
Donald fixed this today, but it does not appear that he's pushed new
snapshots to the repo yet, so I haven't been able to test against the
new jars. I did make an attempt at creating a geronimo bundle from
these jars, but ran into some resource loading issues between the
openjpa jar and the openjpa-persistence-jdbc jars that I was never able
to work out. I tried building openjpa locally, but ran into a couple of
dependency issues I haven't had the chance to chase down.
So, the build is sort of broken in its current state. The Geronimo code
won't compile against the current spec jar without changes and the
openjpa2 plugin can't build with the current openjpa snapshot because of
the missing bundle information. Should I
1) back off the spec change
2) check in the changes to fix the compile errors and use the new
openjpa snapshot and wait for the new snapshot of openjpa to show up
Rick
Re: OpenJPA2 build breakage in trunk
Posted by Donald Woods <dw...@apache.org>.
I hadn't upgraded trunk to use the latest OpenJPA 2.0.0-SNAPSHOT, as I
new there was code changes needed in the openjpa modules to some changes
in the final spec api. I'm busy working on a OpenJPA 2.0.0-beta release
right now, so it'll be a day or two before I can take a look at this.
For now, I would suggest backing out Ivan's changes until I have the
Beta artifacts out on the repos.
-Donald
On 1/22/10 1:14 PM, Rick McGuire wrote:
> There's a nasty build breakage in trunk caused by switching to the
> latest jpa 2.0 spec jar from the one used for the OpenJPA milestone
> release. This change requires some code changes to the Geronimo code
> because some methods were removed and some classes were moved to
> different package locations. I've got the code compiling cleanly with
> the new spec jar, but that just moved things on to another problem.
>
> The next problem to arise came from the mismatch between the OpenJPA
> 2.0.0-M3 release and this spec jar. The M3 OpenJPA code still had
> references to classes in the old package locations, so we ended up with
> ClassNotFoundExceptions while trying to build. Ok, this should be a
> simple fix...it just requires changing the OpenJPA version to the
> 2.0.0-SNAPSHOT level. And here is where things start to get nasty. The
> current trunk code for OpenJPA no longer builds the OpenJPA jars as
> bundles. This issue was already noticed by the Aries folks and a Jira
> was opened on it:
>
> https://issues.apache.org/jira/browse/OPENJPA-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>
>
> Donald fixed this today, but it does not appear that he's pushed new
> snapshots to the repo yet, so I haven't been able to test against the
> new jars. I did make an attempt at creating a geronimo bundle from
> these jars, but ran into some resource loading issues between the
> openjpa jar and the openjpa-persistence-jdbc jars that I was never able
> to work out. I tried building openjpa locally, but ran into a couple of
> dependency issues I haven't had the chance to chase down.
>
> So, the build is sort of broken in its current state. The Geronimo code
> won't compile against the current spec jar without changes and the
> openjpa2 plugin can't build with the current openjpa snapshot because of
> the missing bundle information. Should I
>
> 1) back off the spec change
> 2) check in the changes to fix the compile errors and use the new
> openjpa snapshot and wait for the new snapshot of openjpa to show up
>
> Rick
>
Re: OpenJPA2 build breakage in trunk
Posted by Jarek Gawor <jg...@gmail.com>.
I vote for option 1. I would like to have a working trunk so that I
can make progress on stuff I work on. Besides, the spec change should
not have been committed without building trunk first.
Jarek
On Fri, Jan 22, 2010 at 1:14 PM, Rick McGuire <ri...@gmail.com> wrote:
> There's a nasty build breakage in trunk caused by switching to the latest
> jpa 2.0 spec jar from the one used for the OpenJPA milestone release. This
> change requires some code changes to the Geronimo code because some methods
> were removed and some classes were moved to different package locations.
> I've got the code compiling cleanly with the new spec jar, but that just
> moved things on to another problem.
>
> The next problem to arise came from the mismatch between the OpenJPA
> 2.0.0-M3 release and this spec jar. The M3 OpenJPA code still had
> references to classes in the old package locations, so we ended up with
> ClassNotFoundExceptions while trying to build. Ok, this should be a simple
> fix...it just requires changing the OpenJPA version to the 2.0.0-SNAPSHOT
> level. And here is where things start to get nasty. The current trunk code
> for OpenJPA no longer builds the OpenJPA jars as bundles. This issue was
> already noticed by the Aries folks and a Jira was opened on it:
>
> https://issues.apache.org/jira/browse/OPENJPA-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>
> Donald fixed this today, but it does not appear that he's pushed new
> snapshots to the repo yet, so I haven't been able to test against the new
> jars. I did make an attempt at creating a geronimo bundle from these jars,
> but ran into some resource loading issues between the openjpa jar and the
> openjpa-persistence-jdbc jars that I was never able to work out. I tried
> building openjpa locally, but ran into a couple of dependency issues I
> haven't had the chance to chase down.
>
> So, the build is sort of broken in its current state. The Geronimo code
> won't compile against the current spec jar without changes and the openjpa2
> plugin can't build with the current openjpa snapshot because of the missing
> bundle information. Should I
>
> 1) back off the spec change
> 2) check in the changes to fix the compile errors and use the new openjpa
> snapshot and wait for the new snapshot of openjpa to show up
>
> Rick
>
Re: OpenJPA2 build breakage in trunk
Posted by Rick McGuire <ri...@gmail.com>.
On 1/22/2010 2:11 PM, David Jencks wrote:
> Judging from some activity on the openjpa mailing list I think donald
> would be available to push some snapshots later today so I'd suggest
> waiting an hour or two to see if (2) is possible. If that doesn't work
> out then (1) would be better.
>
> Is there a rev # or two that people could revert locally to get a
> buildable trunck?
It looks like the problem was introduced with rev 902033, which made a
number of changes besides the one causing the problem.
Rick
>
> thanks
> david jencks
>
> On Jan 22, 2010, at 10:14 AM, Rick McGuire wrote:
>
>> There's a nasty build breakage in trunk caused by switching to the
>> latest jpa 2.0 spec jar from the one used for the OpenJPA milestone
>> release. This change requires some code changes to the Geronimo code
>> because some methods were removed and some classes were moved to
>> different package locations. I've got the code compiling cleanly
>> with the new spec jar, but that just moved things on to another problem.
>>
>> The next problem to arise came from the mismatch between the OpenJPA
>> 2.0.0-M3 release and this spec jar. The M3 OpenJPA code still had
>> references to classes in the old package locations, so we ended up
>> with ClassNotFoundExceptions while trying to build. Ok, this should
>> be a simple fix...it just requires changing the OpenJPA version to
>> the 2.0.0-SNAPSHOT level. And here is where things start to get
>> nasty. The current trunk code for OpenJPA no longer builds the
>> OpenJPA jars as bundles. This issue was already noticed by the Aries
>> folks and a Jira was opened on it:
>>
>> https://issues.apache.org/jira/browse/OPENJPA-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>
>>
>> Donald fixed this today, but it does not appear that he's pushed new
>> snapshots to the repo yet, so I haven't been able to test against the
>> new jars. I did make an attempt at creating a geronimo bundle from
>> these jars, but ran into some resource loading issues between the
>> openjpa jar and the openjpa-persistence-jdbc jars that I was never
>> able to work out. I tried building openjpa locally, but ran into a
>> couple of dependency issues I haven't had the chance to chase down.
>>
>> So, the build is sort of broken in its current state. The Geronimo
>> code won't compile against the current spec jar without changes and
>> the openjpa2 plugin can't build with the current openjpa snapshot
>> because of the missing bundle information. Should I
>>
>> 1) back off the spec change
>> 2) check in the changes to fix the compile errors and use the new
>> openjpa snapshot and wait for the new snapshot of openjpa to show up
>>
>> Rick
>
>
Re: OpenJPA2 build breakage in trunk
Posted by David Jencks <da...@yahoo.com>.
Judging from some activity on the openjpa mailing list I think donald
would be available to push some snapshots later today so I'd suggest
waiting an hour or two to see if (2) is possible. If that doesn't work
out then (1) would be better.
Is there a rev # or two that people could revert locally to get a
buildable trunck?
thanks
david jencks
On Jan 22, 2010, at 10:14 AM, Rick McGuire wrote:
> There's a nasty build breakage in trunk caused by switching to the
> latest jpa 2.0 spec jar from the one used for the OpenJPA milestone
> release. This change requires some code changes to the Geronimo
> code because some methods were removed and some classes were moved
> to different package locations. I've got the code compiling cleanly
> with the new spec jar, but that just moved things on to another
> problem.
>
> The next problem to arise came from the mismatch between the OpenJPA
> 2.0.0-M3 release and this spec jar. The M3 OpenJPA code still had
> references to classes in the old package locations, so we ended up
> with ClassNotFoundExceptions while trying to build. Ok, this should
> be a simple fix...it just requires changing the OpenJPA version to
> the 2.0.0-SNAPSHOT level. And here is where things start to get
> nasty. The current trunk code for OpenJPA no longer builds the
> OpenJPA jars as bundles. This issue was already noticed by the
> Aries folks and a Jira was opened on it:
>
> https://issues.apache.org/jira/browse/OPENJPA-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>
> Donald fixed this today, but it does not appear that he's pushed new
> snapshots to the repo yet, so I haven't been able to test against
> the new jars. I did make an attempt at creating a geronimo bundle
> from these jars, but ran into some resource loading issues between
> the openjpa jar and the openjpa-persistence-jdbc jars that I was
> never able to work out. I tried building openjpa locally, but ran
> into a couple of dependency issues I haven't had the chance to chase
> down.
>
> So, the build is sort of broken in its current state. The Geronimo
> code won't compile against the current spec jar without changes and
> the openjpa2 plugin can't build with the current openjpa snapshot
> because of the missing bundle information. Should I
>
> 1) back off the spec change
> 2) check in the changes to fix the compile errors and use the new
> openjpa snapshot and wait for the new snapshot of openjpa to show up
>
> Rick