[GitHub] leventov commented on a change in pull request #6473: QueryCountStatsMonitor: emit query/total/count

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6473: QueryCountStatsMonitor: emit query/total/count
URL: https://github.com/apache/incubator-druid/pull/6473#discussion_r225592647
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/metrics/QueryCountStatsMonitor.java
 ##########
 @@ -46,7 +46,8 @@ public boolean doMonitor(ServiceEmitter emitter)
     final ServiceMetricEvent.Builder builder = new ServiceMetricEvent.Builder();
     Map<String, Long> diff = keyedDiff.to(
         "queryCountStats",
-        ImmutableMap.of("query/success/count", statsProvider.getSuccessfulQueryCount(),
+        ImmutableMap.of("query/total/count", statsProvider.getSuccessfulQueryCount() + statsProvider.getFailedQueryCount(),
 
 Review comment:
   I think metric names should add slashes when some different options are imaginable after the slash. With this, I think just `query/count` or `query/count/total` (with another option of `query/count/delta` is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org