[GitHub] [incubator-tvm] zhanghaohit commented on pull request #5471: [VTA][Runtime] fix hardcoded VerifyDep step

[GitBox <gi...@apache.org>]

zhanghaohit commented on pull request #5471:
URL: https://github.com/apache/incubator-tvm/pull/5471#issuecomment-621572608


   > Thanks @zhanghaohit for the proposed change, moving away from a hardcoded value is the right move!
   > 
   > I find the `ACC_DEP_DISTANCE` to be confusing however. Ultimately it's derived from the latency (in cycles) it takes for a write to address `X` to be visible on the read port at address `X`. Maybe we can dub this `SRAM_WRITE_TO_READ_LATENCY` or something along those lines?
   
   Thanks @tmoreau89 for the suggestion. I think `VerifyDep` here is to [`verify that we don't write to the same acc_mem index two cycles in a row`](https://github.com/apache/incubator-tvm/blob/684f2d7b89e29b92cdac5389df58ba5a70782c2a/vta/runtime/runtime.cc#L289) (I may also need to change the comments).
   
   The `ACC_DEP_DISTANCE` is the same as [here](https://github.com/apache/incubator-tvm-vta/pull/8). Did I get the correct meaning of [`VerifyDep`](https://github.com/apache/incubator-tvm/blob/684f2d7b89e29b92cdac5389df58ba5a70782c2a/vta/runtime/runtime.cc#L290)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org