You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/07/29 04:53:12 UTC

[GitHub] [kylin] zhaojintaozhao commented on a change in pull request #728: KYLIN-4067 optimize the kylin cube page loading mechanism.

zhaojintaozhao commented on a change in pull request #728: KYLIN-4067 optimize the kylin cube page loading mechanism.
URL: https://github.com/apache/kylin/pull/728#discussion_r308055012
 
 

 ##########
 File path: webapp/app/js/controllers/cubeSchema.js
 ##########
 @@ -36,6 +36,8 @@ KylinApp.controller('CubeSchemaCtrl', function ($scope, QueryService, UserServic
     ];
 
     $scope.curStep = $scope.wizardSteps[0];
+    $scope.allCubeNames = [];
+    $scope.cubeService = CubeService;
 
 Review comment:
   Hi， chunen：
   Yes, "$scope.cubeService"  never be used. 
   I will submit code to delete this line tonight.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services