You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/23 17:49:15 UTC

[GitHub] [commons-lang] arturobernalg commented on pull request #716: Reuse the boolean array validations.

arturobernalg commented on pull request #716:
URL: https://github.com/apache/commons-lang/pull/716#issuecomment-784384205


   > Hi @arturobernalg
   > Thank you for your PR. Please see my comments.
   > Ses if you can reuse:
   > 
   > * `ObjectUtils.isEmpty(Object)`
   > * `ObjectUtils.isNotEmpty(Object)`
   >   We could add:
   > * `ObjectUtils.requireNotEmpty(Object)`
   > * `ObjectUtils.requireNotEmpty(Object, String)`
   
   Hi @garydgregory 
   
   I'll check how 
   
   > Hi @arturobernalg
   > Thank you for your PR. Please see my comments.
   > Ses if you can reuse:
   > 
   > * `ObjectUtils.isEmpty(Object)`
   > * `ObjectUtils.isNotEmpty(Object)`
   >   We could add:
   > * `ObjectUtils.requireNotEmpty(Object)`
   > * `ObjectUtils.requireNotEmpty(Object, String)`
   
   Hi @garydgregory 
   
   Thank you for your tips. Is this what you are looking for? I've created a new PR to maintain clean the other one in case I screwed up ;)
   https://github.com/apache/commons-lang/pull/717
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org