[GitHub] [beam] tvalentyn commented on a diff in pull request #25895: Add key param support for helper Combiners

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on code in PR #25895:
URL: https://github.com/apache/beam/pull/25895#discussion_r1144116599


##########
sdks/python/apache_beam/transforms/combiners.py:
##########
@@ -317,7 +317,7 @@ def LargestPerKey(pcoll, n, key=None):
 
   @staticmethod
   @ptransform.ptransform_fn
-  def SmallestPerKey(pcoll, n, key=None, reverse=True):
+  def SmallestPerKey(pcoll, n, *, reverse=True, key=None):

Review Comment:
   given we force KW-only arguments, we can move key before reverse, same as we do in other combiners. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org