[GitHub] [shardingsphere] yu199195 commented on a change in pull request #8974: Fix bug of cannot invoke method hashCode on null object (#8913)

[GitBox <gi...@apache.org>]

yu199195 commented on a change in pull request #8974:
URL: https://github.com/apache/shardingsphere/pull/8974#discussion_r555013704



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java
##########
@@ -63,10 +63,15 @@ private boolean isAllowRangeQuery() {
     }
     
     @Override
-    public String doSharding(final Collection<String> availableTargetNames, final PreciseShardingValue<Comparable<?>> shardingValue) {
-        Closure<?> closure = createClosure();
-        closure.setProperty(shardingValue.getColumnName(), shardingValue.getValue());
-        return closure.call().toString();
+    public String doSharding(Collection<String> availableTargetNames, PreciseShardingValue<Comparable<?>> shardingValue) {

Review comment:
       When will that happen NullPointerException? 
   
   NullPointerException var5  maybe  to  (final NullPointerException e)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org