You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pig.apache.org by "Santhosh Srinivasan (JIRA)" <ji...@apache.org> on 2008/07/17 21:27:31 UTC

[jira] Updated: (PIG-323) Remove DEFINE from QueryParser

     [ https://issues.apache.org/jira/browse/PIG-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santhosh Srinivasan updated PIG-323:
------------------------------------

    Attachment: remove_define_from_query_parser.patch

This patch (remove_define_from_query_parser.patch) 

1. Removes the define keyword and associated methods from the QueryParser. 
2. Re-introduces the keyword and semantics of define in PigScriptParser and Grunt 
3. The test cases in TestLogicalPlanBuilder for define are removed
4. The test case in TestGrunt is modified to handle define
5. Other changes are required due to the constructor change in QueryParser

Unit test cases that still fail are:

    [junit] Running org.apache.pig.test.TestEvalPipeline
    [junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 182.018 sec
    [junit] Test org.apache.pig.test.TestEvalPipeline FAILED

    [junit] Running org.apache.pig.test.TestFilterOpNumeric
    [junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 56.336 sec
    [junit] Test org.apache.pig.test.TestFilterOpNumeric FAILED

    [junit] Running org.apache.pig.test.TestStoreOld
    [junit] Tests run: 3, Failures: 0, Errors: 2, Time elapsed: 21.436 sec
    [junit] Test org.apache.pig.test.TestStoreOld FAILED

> Remove DEFINE from QueryParser
> ------------------------------
>
>                 Key: PIG-323
>                 URL: https://issues.apache.org/jira/browse/PIG-323
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Santhosh Srinivasan
>            Assignee: Santhosh Srinivasan
>            Priority: Minor
>             Fix For: types_branch
>
>         Attachments: remove_define_from_query_parser.patch
>
>
> Remove the keyword DEFINE and the associated methods from QueryParser. The syntax and semantics of define as proposed in the functional specification breaks backward compatibility. The UDFs will now provide the list of function arguments that are expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.