You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/06/18 16:41:15 UTC
[jira] Created: (MPJAR-30) Manifest creation for dependency jars deployed in a sub-directory
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-30
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-30
Summary: Manifest creation for dependency jars deployed in a sub-directory
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Assignee: Jason van Zyl
Reporter: Eric Giguere
Created: Fri, 18 Jun 2004 10:40 AM
Updated: Fri, 18 Jun 2004 10:40 AM
Environment: All OS, no special specs for this feature.
Description:
Library jars are not usually deployed in the same directory than the executable application file. Usually, libraries are deployed in subdirectories of the project root, even sometimes general library paths accessible by many applications.
The change I submit here uses a property you define at the project and that can be overriden for a sinble dependency.
The project property looks like this:
<properties>
<jar.dependency.dist.dir>lib</jar.dependency.dist.dir>
</properties>
The same entry is used in a dependency entry in project.xml.
The code change required in the plugin is this (CVS diff):
***** CVS exited normally with code 0 *****
cvs diff -r 1.1 -r 1.2 -wb -i plugin.jelly plugin.jelly (in directory C:\Work\cvs-nhc-maven\nhc-maven\maven-plugins\jar\)
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/cvsroot/nhc-maven/maven-plugins/jar/plugin.jelly,v
retrieving revision 1.1
retrieving revision 1.2
diff -w -b -i -r1.1 -r1.2
55a56,60
> <!-- Get the project level deployment sub-directory if it exists -->
> <j:if test="${pom.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="projectDepDeployDir" value="${pom.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
>
58c63,69
< <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${dep.artifact}" />
---
> <!-- Set default deploy sub-dir for dependencies to project level property value -->
> <j:set var="depDeployDir" value="${projectDepDeployDir}"/>
> <!-- Check to see if the jar.dependency.deploy.dir was overriden at the dependency level -->
> <j:if test="${dep.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="depDeployDir" value="${dep.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
> <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${depDeployDir}${dep.artifact}" />
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJAR-30) Manifest creation for dependency jars deployed in a sub-directory
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Eric Giguere
Created: Tue, 6 Jul 2004 2:30 PM
Body:
Hello.
Finally, here is the CVS diff run against jar plugin v1.6
A note.. I've submitted another change (the includes) for the plugin. The change was integrated a while ago but was removed from version 1.6. Is there a reason??
Anyway, I'll submit here both diffs:
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/cvsroot/nhc-maven/maven-plugins/jar/plugin.jelly,v
retrieving revision 1.3
diff -w -b -i -r1.3 plugin.jelly
83c83,84
< excludes="${maven.jar.excludes}">
---
> excludes="${maven.jar.excludes}"
> includes="${maven.jar.includes}">
And here is the new addition to allow sub-dir deployment of dependency jars with Jar manifest classpath updated accordingly.
105a107,111
> <!-- Get the project level deployment sub-directory if it exists -->
> <j:if test="${pom.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="projectDepDeployDir" value="${pom.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
>
108c114,120
< <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${dep.artifact}" />
---
> <!-- Set default deploy sub-dir for dependencies to project level property value -->
> <j:set var="depDeployDir" value="${projectDepDeployDir}"/>
> <!-- Check to see if the jar.dependency.deploy.dir was overriden at the dependency level -->
> <j:if test="${dep.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="depDeployDir" value="${dep.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
> <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${depDeployDir}${dep.artifact}" />
***** CVS exited normally with code 1 *****
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJAR-30?page=comments#action_21442
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-30
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-30
Summary: Manifest creation for dependency jars deployed in a sub-directory
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Assignee: Jason van Zyl
Reporter: Eric Giguere
Created: Fri, 18 Jun 2004 10:40 AM
Updated: Tue, 6 Jul 2004 2:30 PM
Environment: All OS, no special specs for this feature.
Description:
Library jars are not usually deployed in the same directory than the executable application file. Usually, libraries are deployed in subdirectories of the project root, even sometimes general library paths accessible by many applications.
The change I submit here uses a property you define at the project and that can be overriden for a sinble dependency.
The project property looks like this:
<properties>
<jar.dependency.dist.dir>lib</jar.dependency.dist.dir>
</properties>
The same entry is used in a dependency entry in project.xml.
The code change required in the plugin is this (CVS diff):
***** CVS exited normally with code 0 *****
cvs diff -r 1.1 -r 1.2 -wb -i plugin.jelly plugin.jelly (in directory C:\Work\cvs-nhc-maven\nhc-maven\maven-plugins\jar\)
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/cvsroot/nhc-maven/maven-plugins/jar/plugin.jelly,v
retrieving revision 1.1
retrieving revision 1.2
diff -w -b -i -r1.1 -r1.2
55a56,60
> <!-- Get the project level deployment sub-directory if it exists -->
> <j:if test="${pom.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="projectDepDeployDir" value="${pom.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
>
58c63,69
< <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${dep.artifact}" />
---
> <!-- Set default deploy sub-dir for dependencies to project level property value -->
> <j:set var="depDeployDir" value="${projectDepDeployDir}"/>
> <!-- Check to see if the jar.dependency.deploy.dir was overriden at the dependency level -->
> <j:if test="${dep.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="depDeployDir" value="${dep.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
> <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${depDeployDir}${dep.artifact}" />
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJAR-30) Manifest creation for dependency jars deployed in a sub-directory
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Eric Giguere (mailto:eric.giguere@videotron.ca)
Date: Fri, 18 Jun 2004 2:12 PM
Comment:
Added the whole plugin.jelly file since I've just realize that the CVS diff i've put in the description is not right... Its a diff against an already modified version of the file. Won't do much good to you guys. Sorry about that.
Changes:
Attachment changed to plugin.jelly
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJAR-30?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-30
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-30
Summary: Manifest creation for dependency jars deployed in a sub-directory
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Assignee: Jason van Zyl
Reporter: Eric Giguere
Created: Fri, 18 Jun 2004 10:40 AM
Updated: Fri, 18 Jun 2004 2:12 PM
Environment: All OS, no special specs for this feature.
Description:
Library jars are not usually deployed in the same directory than the executable application file. Usually, libraries are deployed in subdirectories of the project root, even sometimes general library paths accessible by many applications.
The change I submit here uses a property you define at the project and that can be overriden for a sinble dependency.
The project property looks like this:
<properties>
<jar.dependency.dist.dir>lib</jar.dependency.dist.dir>
</properties>
The same entry is used in a dependency entry in project.xml.
The code change required in the plugin is this (CVS diff):
***** CVS exited normally with code 0 *****
cvs diff -r 1.1 -r 1.2 -wb -i plugin.jelly plugin.jelly (in directory C:\Work\cvs-nhc-maven\nhc-maven\maven-plugins\jar\)
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/cvsroot/nhc-maven/maven-plugins/jar/plugin.jelly,v
retrieving revision 1.1
retrieving revision 1.2
diff -w -b -i -r1.1 -r1.2
55a56,60
> <!-- Get the project level deployment sub-directory if it exists -->
> <j:if test="${pom.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="projectDepDeployDir" value="${pom.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
>
58c63,69
< <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${dep.artifact}" />
---
> <!-- Set default deploy sub-dir for dependencies to project level property value -->
> <j:set var="depDeployDir" value="${projectDepDeployDir}"/>
> <!-- Check to see if the jar.dependency.deploy.dir was overriden at the dependency level -->
> <j:if test="${dep.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="depDeployDir" value="${dep.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
> <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${depDeployDir}${dep.artifact}" />
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJAR-30) Manifest creation for dependency jars deployed in a sub-directory
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Eric Giguere
Created: Tue, 22 Jun 2004 1:29 PM
Body:
Hey!
Sure, I'll do that.
I'll get back on Maven RC1 build (currently working with a snapshot of 1.1 version) and update all plugins to insert this patch.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJAR-30?page=comments#action_20909
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-30
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-30
Summary: Manifest creation for dependency jars deployed in a sub-directory
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Assignee: Jason van Zyl
Reporter: Eric Giguere
Created: Fri, 18 Jun 2004 10:40 AM
Updated: Tue, 22 Jun 2004 1:29 PM
Environment: All OS, no special specs for this feature.
Description:
Library jars are not usually deployed in the same directory than the executable application file. Usually, libraries are deployed in subdirectories of the project root, even sometimes general library paths accessible by many applications.
The change I submit here uses a property you define at the project and that can be overriden for a sinble dependency.
The project property looks like this:
<properties>
<jar.dependency.dist.dir>lib</jar.dependency.dist.dir>
</properties>
The same entry is used in a dependency entry in project.xml.
The code change required in the plugin is this (CVS diff):
***** CVS exited normally with code 0 *****
cvs diff -r 1.1 -r 1.2 -wb -i plugin.jelly plugin.jelly (in directory C:\Work\cvs-nhc-maven\nhc-maven\maven-plugins\jar\)
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/cvsroot/nhc-maven/maven-plugins/jar/plugin.jelly,v
retrieving revision 1.1
retrieving revision 1.2
diff -w -b -i -r1.1 -r1.2
55a56,60
> <!-- Get the project level deployment sub-directory if it exists -->
> <j:if test="${pom.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="projectDepDeployDir" value="${pom.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
>
58c63,69
< <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${dep.artifact}" />
---
> <!-- Set default deploy sub-dir for dependencies to project level property value -->
> <j:set var="depDeployDir" value="${projectDepDeployDir}"/>
> <!-- Check to see if the jar.dependency.deploy.dir was overriden at the dependency level -->
> <j:if test="${dep.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="depDeployDir" value="${dep.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
> <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${depDeployDir}${dep.artifact}" />
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJAR-30) Manifest creation for dependency jars deployed in a sub-directory
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Emmanuel Venisse
Created: Sat, 19 Jun 2004 8:40 AM
Body:
Can you create a correct patch with the file present in cvs? Your plugin.jelly suppress a lot of lines.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJAR-30?page=comments#action_20832
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-30
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-30
Summary: Manifest creation for dependency jars deployed in a sub-directory
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Assignee: Jason van Zyl
Reporter: Eric Giguere
Created: Fri, 18 Jun 2004 10:40 AM
Updated: Sat, 19 Jun 2004 8:40 AM
Environment: All OS, no special specs for this feature.
Description:
Library jars are not usually deployed in the same directory than the executable application file. Usually, libraries are deployed in subdirectories of the project root, even sometimes general library paths accessible by many applications.
The change I submit here uses a property you define at the project and that can be overriden for a sinble dependency.
The project property looks like this:
<properties>
<jar.dependency.dist.dir>lib</jar.dependency.dist.dir>
</properties>
The same entry is used in a dependency entry in project.xml.
The code change required in the plugin is this (CVS diff):
***** CVS exited normally with code 0 *****
cvs diff -r 1.1 -r 1.2 -wb -i plugin.jelly plugin.jelly (in directory C:\Work\cvs-nhc-maven\nhc-maven\maven-plugins\jar\)
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/cvsroot/nhc-maven/maven-plugins/jar/plugin.jelly,v
retrieving revision 1.1
retrieving revision 1.2
diff -w -b -i -r1.1 -r1.2
55a56,60
> <!-- Get the project level deployment sub-directory if it exists -->
> <j:if test="${pom.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="projectDepDeployDir" value="${pom.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
>
58c63,69
< <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${dep.artifact}" />
---
> <!-- Set default deploy sub-dir for dependencies to project level property value -->
> <j:set var="depDeployDir" value="${projectDepDeployDir}"/>
> <!-- Check to see if the jar.dependency.deploy.dir was overriden at the dependency level -->
> <j:if test="${dep.getProperty('jar.dependency.dist.dir')!=null}">
> <j:set var="depDeployDir" value="${dep.getProperty('jar.dependency.dist.dir')}${'/'}"/>
> </j:if>
> <j:set var="maven.jar.classpath" value="${maven.jar.classpath} ${depDeployDir}${dep.artifact}" />
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org