You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "nkeywal (Commented) (JIRA)" <ji...@apache.org> on 2011/11/12 16:52:51 UTC

[jira] [Commented] (HBASE-4764) naming errors for TestHLogUtils and SoftValueSortedMapTest

    [ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149099#comment-13149099 ] 

nkeywal commented on HBASE-4764:
--------------------------------

@committers: please tell if you're ok with:
- TestHLogUtils: renaming
- SoftValueSortedMapTest: renaming + JUnitization if included tests works, deletion otherwise.
                
> naming errors for TestHLogUtils and SoftValueSortedMapTest
> ----------------------------------------------------------
>
>                 Key: HBASE-4764
>                 URL: https://issues.apache.org/jira/browse/HBASE-4764
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's not called. I don't know if it's used.
> TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses the script looking for the tests. It would seems a better thing to rename it. Is there anything special to do to keep the history attached to this file?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira