You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2021/02/20 13:41:47 UTC

[GitHub] [isis] ErnoViitanen-LUT opened a new pull request #391: ISIS-1678: replace with ClockService

ErnoViitanen-LUT opened a new pull request #391:
URL: https://github.com/apache/isis/pull/391


   Remove org.apache.isis.applib.clock.Clock, replace with org.apache.isis.applib.services.clock.ClockService


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis] andi-huber closed pull request #391: ISIS-1678: replace with ClockService

Posted by GitBox <gi...@apache.org>.
andi-huber closed pull request #391:
URL: https://github.com/apache/isis/pull/391


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis] andi-huber commented on pull request #391: ISIS-1678: replace with ClockService

Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #391:
URL: https://github.com/apache/isis/pull/391#issuecomment-782809511


   I think its save to assume, that https://issues.apache.org/jira/browse/ISIS-1678 can already be considered resolved. The `VirtualClock` was only introduced lately. And has a different use-case within the framework than the previous `Clock` had. I'd rather not move it.
   
   Hope you don't mind if I close this PR without merging. Needless to say its much appreciated seeing PRs and people that want to help getting tasks done. Thumbs up!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis] danhaywood commented on pull request #391: ISIS-1678: replace with ClockService

Posted by GitBox <gi...@apache.org>.
danhaywood commented on pull request #391:
URL: https://github.com/apache/isis/pull/391#issuecomment-782843379


   Hi Erno,
   and to echo what Andi says - join our Slack channel and have a chat first
   about what you'd like to work on
   Thanks
   Dan
   
   On Sun, 21 Feb 2021 at 06:51, Andi Huber <no...@github.com> wrote:
   
   > Oh @ErnoViitanen-LUT <https://github.com/ErnoViitanen-LUT> - and by the
   > way, if thats your first PR ever. Cool stuff, keep going!
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/isis/pull/391#issuecomment-782810389>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAH33SN2QQZ66CVD2RL7HY3TACUQJANCNFSM4X54OZ5Q>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis] andi-huber commented on pull request #391: ISIS-1678: replace with ClockService

Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #391:
URL: https://github.com/apache/isis/pull/391#issuecomment-782810389


   Oh @ErnoViitanen-LUT - and by the way, if thats your first PR ever. Cool stuff, keep going!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org