You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/18 12:36:43 UTC
Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67215/
-----------------------------------------------------------
Review request for mesos, Jie Yu and James Peach.
Repository: mesos
Description
-------
Opened subprocess pipes with `O_CLOEXEC`.
Diffs
-----
3rdparty/libprocess/src/subprocess.cpp d7a725363251f9c54072cd7551f5598696938308
3rdparty/libprocess/src/subprocess_posix.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
Diff: https://reviews.apache.org/r/67215/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67215/#review203415
-----------------------------------------------------------
PASS: Mesos patch 67215 was successfully built and tested.
Reviews applied: `['67215']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67215
- Mesos Reviewbot Windows
On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67215/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 12:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Opened subprocess pipes with `O_CLOEXEC`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp d7a725363251f9c54072cd7551f5598696938308
> 3rdparty/libprocess/src/subprocess_posix.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
>
>
> Diff: https://reviews.apache.org/r/67215/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.
Posted by cf...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67215/#review224652
-----------------------------------------------------------
Bad patch!
Reviews applied: [67215]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 67215
Error:
2022-09-07 22:23:52 URL:https://reviews.apache.org/r/67215/diff/raw/ [1666/1666] -> "67215.patch" [1]
error: 3rdparty/libprocess/src/subprocess_posix.cpp: does not exist in index
- cf.natali
On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67215/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 12:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Opened subprocess pipes with `O_CLOEXEC`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp d7a725363251f9c54072cd7551f5598696938308
> 3rdparty/libprocess/src/subprocess_posix.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
>
>
> Diff: https://reviews.apache.org/r/67215/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67215/#review203500
-----------------------------------------------------------
3rdparty/libprocess/src/subprocess_posix.cpp
Line 50 (original), 50 (patched)
<https://reviews.apache.org/r/67215/#comment285791>
AFAICT `pipe2(2)` is available on Linux and FreeBSD but not macOS.
- James Peach
On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67215/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 12:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Opened subprocess pipes with `O_CLOEXEC`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp d7a725363251f9c54072cd7551f5598696938308
> 3rdparty/libprocess/src/subprocess_posix.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
>
>
> Diff: https://reviews.apache.org/r/67215/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>