You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Sharad Agarwal (JIRA)" <ji...@apache.org> on 2008/11/07 09:20:45 UTC
[jira] Created: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Remove RunJar's dependency on JobClient
---------------------------------------
Key: HADOOP-4612
URL: https://issues.apache.org/jira/browse/HADOOP-4612
Project: Hadoop Core
Issue Type: Sub-task
Reporter: Sharad Agarwal
Assignee: Sharad Agarwal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-4612:
-----------------------------------
Attachment: 4188_v2.patch
Fixed the Thread context classloader in GenericOptionsParser. Earlier it was overwriting the Thread context classloader.
Tested that following is able to load the class from libjars at the client side:
hadoop jar streaming.jar -libjars test.jar -input input -output out -inputformat <class from test jar>
Also tested that classes from streaming.jar can be loaded via StreamUtil#goodClassOrNull
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 4188_v2.patch, 4612_v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-4612:
-----------------------------------
Attachment: 4612_v1.patch
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 4612_v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647254#action_12647254 ]
Amareshwari Sriramadasu commented on HADOOP-4612:
-------------------------------------------------
+1 patch looks good.
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 4612_v1.patch, 4612_v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-4612:
-----------------------------------
Attachment: 4612_v2.patch
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 4612_v1.patch, 4612_v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-4612:
-----------------------------------
Fix Version/s: 0.20.0
Status: Patch Available (was: Open)
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Fix For: 0.20.0
>
> Attachments: 4612_v1.patch, 4612_v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4612:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Sharad!
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Fix For: 0.20.0
>
> Attachments: 4612_v1.patch, 4612_v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647576#action_12647576 ]
Hadoop QA commented on HADOOP-4612:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393850/4612_v2.patch
against trunk revision 713893.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3591/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3591/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3591/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3591/console
This message is automatically generated.
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Fix For: 0.20.0
>
> Attachments: 4612_v1.patch, 4612_v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647199#action_12647199 ]
Amareshwari Sriramadasu commented on HADOOP-4612:
-------------------------------------------------
We might have to verify Configuration.getClassByName() doesn't bypass currentThread's contextClassLoader.
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 4612_v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-4612:
-----------------------------------
Attachment: (was: 4188_v2.patch)
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 4612_v1.patch, 4612_v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4612) Remove RunJar's dependency on
JobClient
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646252#action_12646252 ]
Sharad Agarwal commented on HADOOP-4612:
----------------------------------------
Following code was added as part of HADOOP-3570 :
{code}
//adding libjars to the classpath
Configuration conf = JobClient.getCommandLineConfig();
URL[] libJars = GenericOptionsParser.getLibJars(conf);
if(libJars!=null) {
for(URL url : libJars){
classPath.add(url);
}
}
{code}
This is no more required after HADOOP-3722. However currently the classes loaded in StreamUtil via Class.forName is incorrect. It should use Configuration#getClassByName to load the libjars' classes set in the conf classloader by GenericOptionsParser.
> Remove RunJar's dependency on JobClient
> ---------------------------------------
>
> Key: HADOOP-4612
> URL: https://issues.apache.org/jira/browse/HADOOP-4612
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.