You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Nisden (via GitHub)" <gi...@apache.org> on 2023/06/22 09:27:56 UTC
[GitHub] [superset] Nisden opened a new pull request, #24482: fix(permalink): Incorrect component schema reference
Nisden opened a new pull request, #24482:
URL: https://github.com/apache/superset/pull/24482
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
During a recent migration the schema reference was not updated
https://github.com/apache/superset/commit/71d0543f28711ed70fcfb8086489661596aa2075
### TESTING INSTRUCTIONS
Verify that OpenAPI request `/api/v1/dashboard/{pk}/permalink` references an existing schema
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24482: fix(permalink): Incorrect component schema reference
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24482:
URL: https://github.com/apache/superset/pull/24482#issuecomment-1604556990
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24482](https://app.codecov.io/gh/apache/superset/pull/24482?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c67df34) into [master](https://app.codecov.io/gh/apache/superset/commit/2a4ef5cccf3d3f8f2f7ccfc8c590f8f2fde31ab0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2a4ef5c) will **decrease** coverage by `11.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c67df34 differs from pull request most recent head 191c4a7. Consider uploading reports for the commit 191c4a7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24482 +/- ##
===========================================
- Coverage 69.03% 58.02% -11.01%
===========================================
Files 1901 1901
Lines 74006 74006
Branches 8115 8115
===========================================
- Hits 51088 42944 -8144
- Misses 20807 28951 +8144
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.79% <ø> (ø)` | |
| python | `60.59% <ø> (-22.90%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.65% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/permalink/api.py](https://app.codecov.io/gh/apache/superset/pull/24482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvYXBpLnB5) | `61.11% <ø> (-27.78%)` | :arrow_down: |
... and [300 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24482/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24482: fix(permalink): Incorrect component schema reference
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24482:
URL: https://github.com/apache/superset/pull/24482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org