[GitHub] adityaxavier commented on a change in pull request #202: Beacon's Measured Power as an argument

[GitBox <gi...@apache.org>]

adityaxavier commented on a change in pull request #202: Beacon's Measured Power as an argument
URL: https://github.com/apache/mynewt-nimble/pull/202#discussion_r222234418
 
 

 ##########
 File path: nimble/host/src/ble_ibeacon.c
 ##########
 @@ -59,13 +60,11 @@ ble_ibeacon_set_adv_data(void *uuid128, uint16_t major, uint16_t minor)
     put_be16(buf + 20, major);
     put_be16(buf + 22, minor);
 
-    /** Last byte (tx power level) filled in after HCI exchange. */
-
-    rc = ble_hs_hci_util_read_adv_tx_pwr(&tx_pwr);
-    if (rc != 0) {
-        return rc;
+    /* Measured Power ranging data (Calibrated tx power at 1 meters). */
+    if (measured_power < -100 || measured_power > 20) {
 
 Review comment:
   Hmm, I check the link :-
   https://www.bluetooth.com/specifications/gatt/viewer?attributeXmlFile=org.bluetooth.characteristic.tx_power_level.xml&u=org.bluetooth.characteristic.tx_power_level.xml
   
   It says -100 to 20, is the range. Am I looking at the wrong value ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services