You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/02/22 15:55:27 UTC

[GitHub] flink pull request: [FLINK-3464] [docs] Add SBT template documenta...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1688

    [FLINK-3464] [docs] Add SBT template documentation to the quickstart documentation

    This PR also changes the order of the shown tabs for the java api quickstart guide. Now the maven archetype is the active tab, because people are usually wary of some ominous scripts.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink addSbtDoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1688
    
----
commit b7022206a4e404b52865a864c369dc44d6747e35
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-22T14:50:55Z

    [FLINK-3464] [docs] Add SBT template documentation to the quickstart documentation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3464] [docs] Add SBT template documenta...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1688#issuecomment-188265759
  
    I agree that giter8 might not be so popular. However, the giter8 template has the advantage that you can easily customize the project (selecting name, version, scala version, flink version, etc.). Moreover, it automatically retrieves the latest Flink version from Maven central. Thus, the template should not outdate if the API's aren't broken.
    
    But we can also change the order of the tabs so that cloning of the repo is the first choice if you think this is the better option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3464] [docs] Add SBT template documenta...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3464] [docs] Add SBT template documenta...

Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the pull request:

    https://github.com/apache/flink/pull/1688#issuecomment-188258580
  
    Thanks for this and fixing the SBT build, this should greatly help setting up new users in demonstrations etc.
    
    @tillrohrmann Any reason giter8 was selected as the default tab? Simply cloning the repo without asking the users to install some tool (I've never seen before) makes more sense doesn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3464] [docs] Add SBT template documenta...

Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the pull request:

    https://github.com/apache/flink/pull/1688#issuecomment-188278485
  
    In terms of usability I think it is.The whole point of the quickstart guide is to get users up and running as quickly as possible. For their first toy project people probably will not care about the customization that giter8 offers.
    
    Most importantly adding the requirement to go to some website that asks you to curl a script and pipe it to bash (which is something this commit actually fixes on the Flink side) to install *another* tool (Conscript) that will let you install the original tool is too much effort for a *quick*start guide.
    
    So I vote for the `git clone` default, with giter8 as an option.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3464] [docs] Add SBT template documenta...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1688#issuecomment-187605677
  
    Will merge the documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---