[jira] [Issue Comment Edited] (NPANDAY-533) Refactor wix-maven-plugin to reduce duplication

["Brett Porter (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188237#comment-13188237 ] 

Brett Porter edited comment on NPANDAY-533 at 1/18/12 4:31 AM:
---------------------------------------------------------------

I also had to add a check that cultures was not empty (seems it was string[0]), as IT007 was failing with argument {{-cultures:}}

I also undid the change that did things like {{args.add( "-ext " + ext );}} as it got incorrectly quoted. It should be {{args.add( "-ext" ); args.add( ext ); }} as originally.

Does that look right to you?
                
      was (Author: brettporter):
    I also had to add a check that cultures was not empty (seems it was string[0]), as IT007 was failing with argument {{-cultures:}}

Does that look right to you?
                  
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
>                 Key: NPANDAY-533
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-533
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.5.0-incubating
>            Reporter: Adrián Boimvaser
>            Assignee: Brett Porter
>             Fix For: 1.5.0-incubating
>
>         Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
>   can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira