You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/14 11:58:54 UTC

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1298: fix: Login page bottom white background.

guoqqqi opened a new pull request #1298:
URL: https://github.com/apache/apisix-dashboard/pull/1298


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   Change the global.less background-color.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1298: fix: Login page bottom white background.

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1298:
URL: https://github.com/apache/apisix-dashboard/pull/1298#discussion_r557873105



##########
File path: web/src/global.less
##########
@@ -21,6 +21,7 @@ body,
 #root {
   height: 100%;
   word-break: break-word;
+  background-color: #f0f2f5;

Review comment:
       ```suggestion
     background-color: @layout-body-background;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1298: fix: Login page bottom white background.

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1298:
URL: https://github.com/apache/apisix-dashboard/pull/1298


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1298: fix: Login page bottom white background.

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1298:
URL: https://github.com/apache/apisix-dashboard/pull/1298#issuecomment-760158339


   @nic-chen @starsz backend e2e failed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org