You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2025/02/24 17:11:12 UTC
(spark) branch master updated: [SPARK-51156][CONNECT][FOLLOWUP] Remove unused `private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient`
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 9de3b7c677f1 [SPARK-51156][CONNECT][FOLLOWUP] Remove unused `private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient`
9de3b7c677f1 is described below
commit 9de3b7c677f1cec4f13ba75a170b70d6aa90b306
Author: yangjie01 <ya...@baidu.com>
AuthorDate: Mon Feb 24 09:10:58 2025 -0800
[SPARK-51156][CONNECT][FOLLOWUP] Remove unused `private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient`
### What changes were proposed in this pull request?
This pr aims to remove unused `private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient` because it becomes a useless `private val` declaration after https://github.com/apache/spark/pull/50006.
### Why are the changes needed?
Remove unused `private val`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #50070 from LuciferYang/SPARK-51156-FOLLOWUP.
Authored-by: yangjie01 <ya...@baidu.com>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
.../org/apache/spark/sql/connect/client/SparkConnectClient.scala | 4 ----
1 file changed, 4 deletions(-)
diff --git a/sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala b/sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala
index 57ed45418316..4925c7700b61 100644
--- a/sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala
+++ b/sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala
@@ -406,10 +406,6 @@ object SparkConnectClient {
private val AUTH_TOKEN_META_DATA_KEY: Metadata.Key[String] =
Metadata.Key.of("Authentication", Metadata.ASCII_STRING_MARSHALLER)
- private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG: String =
- "Authentication token cannot be passed over insecure connections. " +
- "Either remove 'token' or set 'use_ssl=true'"
-
// for internal tests
private[sql] def apply(channel: ManagedChannel): SparkConnectClient = {
new SparkConnectClient(Configuration(), channel)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org