You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2011/07/01 14:00:29 UTC
[jira] [Commented] (HDFS-1753) Resource Leak in
org.apache.hadoop.hdfs.server.namenode.StreamFile
[ https://issues.apache.org/jira/browse/HDFS-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058510#comment-13058510 ]
Uma Maheswara Rao G commented on HDFS-1753:
-------------------------------------------
Hi Eli,
Thanks for the patch which includes HDFS-2110 review comments also.
Patch looks good to me.
+1 from my side.
> Resource Leak in org.apache.hadoop.hdfs.server.namenode.StreamFile
> ------------------------------------------------------------------
>
> Key: HDFS-1753
> URL: https://issues.apache.org/jira/browse/HDFS-1753
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-1753.1.patch, HDFS-1753.2.patch, HDFS-1753.3.patch, HDFS-1753.4.patch, HDFS-1753.patch
>
>
> In doGet Method,
> final DFSInputStream in = dfs.open(filename);
> final long fileLen = in.getFileLength();
> OutputStream os = response.getOutputStream();
> Here this lines are present at out side of the try block.
> If response.getOutputStream() throws any exception then DFSInputStream will not be closed.So, better to move response.getOutputStream() into try block.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira