You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/05 08:20:50 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4020: server: move UpdateDefaultNic to vm work job queue
ustcweizhou opened a new pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020
## Description
<!--- Describe your changes in detail -->
While remove secondary nic from a Running vm, if update the default nic to the secondary nic before the nic is removed, the vm will not have default nic (and cannot be started) when both operations are completed.
It is because UpdateDefaultNic api is not handled as a vm work job (AddNicToVMCmd and RemoveNicFromVMCmd are), it is processed before nic is removed. The result is that secondary nic becomes default nic and got removed.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. remove secondary nic from a Running vm
2. update default nic to the secondary nic before step 1 is finished.
3. got an exception as below.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-682470969
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-666576369
@borisstoyanov can you (have someone) test this? seems straight forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-653728122
Packaging result: ✖centos7 ✖debian. JID-1520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-683219755
<b>Trillian test result (tid-2599)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51064 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4020-t2599-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 440.94 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 346.95 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3934.72 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 103.41 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669055258
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669054544
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-665082680
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669762391
@weizhouapache there are conflicts. also do you want this on 4.14 or master only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-653724202
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-682447994
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1838
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-640321657
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-682470460
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-643532095
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-653724165
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-640337781
Packaging result: ✔centos7 ✔debian. JID-1307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-673422466
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-665923515
<b>Trillian test result (tid-2222)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4020-t2222-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 347.36 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-673393541
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-653730680
@ustcweizhou can you check build failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-682421284
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-682421898
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-640321748
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-673411866
Packaging result: ✔centos7 ✔debian. JID-1734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-643550408
Packaging result: ✖centos7 ✖debian. JID-1365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669405206
<b>Trillian test result (tid-2268)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36058 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4020-t2268-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-665082956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-673392959
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-673422642
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-643531901
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-673033253
> @weizhouapache there are conflicts. also do you want this on 4.14 or master only?
@DaanHoogland rebased with latest commit in 4.14 branch.
it would be better to merge it into 4.14 and master both
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org