You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2023/07/13 08:57:34 UTC
[GitHub] [arrow-datafusion] Dandandan opened a new pull request, #6950: Fix required partitioning of Single aggregation mode
Dandandan opened a new pull request, #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6949
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #6950: Fix required partitioning of Single aggregation mode
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950#issuecomment-1634644376
> According to `CombinePartialFinalAggregate` rule, when planner sees `AggregateMode::Partial` + `AggregateMode::Final` or `AggregateMode::Partial` + `AggregateMode::FinalPartitioned`, it replaces these immediate operators with `AggregateMode::Single`. For second case changing distribution requirement to `Distribution::HashPartitioned` makes sense. However, for first case distribution requirement should be `SinglePartition` I guess.
>
> With the proposed changes, `AggregateMode::Single` will require `vec![Distribution::HashPartitioned(vec![])]` (where group by is empty). when it is constructed from `AggregateMode::Partial` + `AggregateMode::Final` stack.
>
> Will this requirement add `RepartitionExec(hash)` during planning?
Ah I missed that part.
I missed the part that `Final` + `FinalPartitioned` is also being converted to `Single`. I think the correct way (that avoids planning errors) would be a `Single` that requires `SinglePartition` in that case.
Currently the optimization rule runs after the `RepartitionExec(hash)` and `CoalescePartitions` are added so it *should* already have those requirements, but I think it's better to generate a correct plan, otherwise we could introduce errors later on (e.g. by a rule that removes unnecessary `RepartitionExec` / `CoalescePartitions` or by using the `Single` mode directly before the required partitioning is added).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on pull request #6950: Fix required partitioning of Single aggregation mode
Posted by "mingmwang (via GitHub)" <gi...@apache.org>.
mingmwang commented on PR #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950#issuecomment-1634432851
@mustafasrepo
I think the purpose of this PR is to extend the use case of `AggregateMode::Single`. I think the change make sense, but it is better to add some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mustafasrepo commented on pull request #6950: Fix required partitioning of Single aggregation mode
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on PR #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950#issuecomment-1634257252
According to `CombinePartialFinalAggregate` rule, when planner sees `AggregateMode::Partial` + `AggregateMode::Final` or `AggregateMode::Partial` + `AggregateMode::FinalPartitioned`, it replaces these immediate operators with `AggregateMode::Single`.
For second case changing distribution requirement to `Distribution::HashPartitioned` makes sense. However, for first case distribution requirement should be `SinglePartition` I guess.
With the proposed changes, `AggregateMode::Single` will require `vec![Distribution::HashPartitioned(vec![])]` (where group by is empty). when it is constructed from `AggregateMode::Partial` + `AggregateMode::Final` stack.
Will this requirement add `RepartitionExec(hash)` during planning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #6950: Fix required partitioning of Single aggregation mode
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #6950: Fix required partitioning of Single aggregation mode
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950#issuecomment-1633843918
FYI @mingmwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #6950: Fix required partitioning of Single aggregation mode
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6950:
URL: https://github.com/apache/arrow-datafusion/pull/6950#issuecomment-1634716294
I added a mode `SinglePartitioned` which requires the input to be partitioned, the existing `Single` mode does require the input to be coalesced into one partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org