You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/21 10:12:30 UTC

[GitHub] [flink] snuyanzin commented on a diff in pull request #19529: [FLINK-27321][ci] Migrate java-ci-tools to JUnit 5

snuyanzin commented on code in PR #19529:
URL: https://github.com/apache/flink/pull/19529#discussion_r855018533


##########
tools/ci/java-ci-tools/src/test/java/org/apache/flink/tools/ci/licensecheck/JarFileCheckerTest.java:
##########
@@ -46,186 +44,209 @@
  * -DaltDeploymentRepository=snapshot-repo::default::file:/tmp/flink-deployment -DskipTests
  * -Drat.skip and add a test checking that directory.
  */
-public class JarFileCheckerTest extends TestLogger {
-
-    @ClassRule public static final TemporaryFolder TMP = new TemporaryFolder();
+class JarFileCheckerTest extends TestLogger {

Review Comment:
   Probably `extends TestLogger` should be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org