You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2013/06/19 22:21:21 UTC
git commit: THRIFT-2012 Modernizing Go Fix for variable ‘field_default_value’ set but not used
Updated Branches:
refs/heads/master 0e87c46c1 -> f713a75a0
THRIFT-2012 Modernizing Go
Fix for variable ‘field_default_value’ set but not used
Patch: jens Geyer
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/f713a75a
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/f713a75a
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/f713a75a
Branch: refs/heads/master
Commit: f713a75a08c455d72364c6bfa5909419e575bc91
Parents: 0e87c46
Author: Jens Geyer <je...@apache.org>
Authored: Tue May 7 11:37:41 2013 +0200
Committer: Jens Geyer <je...@apache.org>
Committed: Tue May 7 11:37:41 2013 +0200
----------------------------------------------------------------------
compiler/cpp/src/generate/t_go_generator.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/f713a75a/compiler/cpp/src/generate/t_go_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_go_generator.cc b/compiler/cpp/src/generate/t_go_generator.cc
index 82af8a8..9abd230 100644
--- a/compiler/cpp/src/generate/t_go_generator.cc
+++ b/compiler/cpp/src/generate/t_go_generator.cc
@@ -1210,7 +1210,7 @@ void t_go_generator::generate_go_struct_writer(ofstream& out,
string field_name;
string escape_field_name;
- t_const_value* field_default_value;
+ //t_const_value* field_default_value;
t_field::e_req field_required;
bool field_can_be_nil = false;
int32_t field_id = -1;
@@ -1277,7 +1277,7 @@ void t_go_generator::generate_go_struct_writer(ofstream& out,
field_id = (*f_iter)->get_key();
field_name = (*f_iter)->get_name();
escape_field_name = escape_string(field_name);
- field_default_value = (*f_iter)->get_value();
+ //field_default_value = (*f_iter)->get_value();
field_required = (*f_iter)->get_req();
field_can_be_nil = can_be_nil((*f_iter)->get_type());