You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Beliaev (JIRA)" <ji...@apache.org> on 2007/04/02 18:20:32 UTC

[jira] Created: (HARMONY-3546) [drlvm][build] smoke tests run does not check exit code

[drlvm][build] smoke tests run does not check exit code
-------------------------------------------------------

                 Key: HARMONY-3546
                 URL: https://issues.apache.org/jira/browse/HARMONY-3546
             Project: Harmony
          Issue Type: Bug
          Components: DRLVM
            Reporter: Vladimir Beliaev


According to HARMONY-3527 (which is caused by committed patch from HARMONY-3065) the massive tests failures were expected.

Still Curise Control shows the some tests passed fine. Accodring to done evaluation the test 'exit' code was not checked, so if test prints PASSED but returns 128 it was considered as passed.

This should be fixed.

While fixing one should note that smoke tests contain several tests which are supposed to exit with non-null value, namly:
init.ErrorInInitializer, shutdown.TestFatalError, shutdown.TestInterrupt...

I've attached the patch fixing the mensioned issue. BTW, it is uses ant "Variable" task for exit code redefinition for set of runs - might be better solution can be used here.

While testing the patch I found the stress/Stack.java fails in JET mode. Still it is excluded in jit/srv/opt modes, it is also excluded for all jitrino modes for linux/em64t. So I've just updated X-list for JET (in the patch).

Thanks
Vladimir Beliaev


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3546) [drlvm][build] smoke tests run does not check exit code

Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Beliaev updated HARMONY-3546:
--------------------------------------

    Patch Info: [Patch Available]

> [drlvm][build] smoke tests run does not check exit code
> -------------------------------------------------------
>
>                 Key: HARMONY-3546
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3546
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Vladimir Beliaev
>         Attachments: H3546.patch
>
>
> According to HARMONY-3527 (which is caused by committed patch from HARMONY-3065) the massive tests failures were expected.
> Still Curise Control shows the some tests passed fine. Accodring to done evaluation the test 'exit' code was not checked, so if test prints PASSED but returns 128 it was considered as passed.
> This should be fixed.
> While fixing one should note that smoke tests contain several tests which are supposed to exit with non-null value, namly:
> init.ErrorInInitializer, shutdown.TestFatalError, shutdown.TestInterrupt...
> I've attached the patch fixing the mensioned issue. BTW, it is uses ant "Variable" task for exit code redefinition for set of runs - might be better solution can be used here.
> While testing the patch I found the stress/Stack.java fails in JET mode. Still it is excluded in jit/srv/opt modes, it is also excluded for all jitrino modes for linux/em64t. So I've just updated X-list for JET (in the patch).
> Thanks
> Vladimir Beliaev

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3546) [drlvm][build] smoke tests run does not check exit code

Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Beliaev updated HARMONY-3546:
--------------------------------------

    Attachment: H3546.patch

Note that I've tested the attached modifications on fresh Harmony version with the HARMONY-3527 patch applied (which undoes HARMONY-3065 changes), so I got the smoke tests passed...

> [drlvm][build] smoke tests run does not check exit code
> -------------------------------------------------------
>
>                 Key: HARMONY-3546
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3546
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Vladimir Beliaev
>         Attachments: H3546.patch
>
>
> According to HARMONY-3527 (which is caused by committed patch from HARMONY-3065) the massive tests failures were expected.
> Still Curise Control shows the some tests passed fine. Accodring to done evaluation the test 'exit' code was not checked, so if test prints PASSED but returns 128 it was considered as passed.
> This should be fixed.
> While fixing one should note that smoke tests contain several tests which are supposed to exit with non-null value, namly:
> init.ErrorInInitializer, shutdown.TestFatalError, shutdown.TestInterrupt...
> I've attached the patch fixing the mensioned issue. BTW, it is uses ant "Variable" task for exit code redefinition for set of runs - might be better solution can be used here.
> While testing the patch I found the stress/Stack.java fails in JET mode. Still it is excluded in jit/srv/opt modes, it is also excluded for all jitrino modes for linux/em64t. So I've just updated X-list for JET (in the patch).
> Thanks
> Vladimir Beliaev

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3546) [drlvm][build] smoke tests run does not check exit code

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-3546.
--------------------------------------


No response, assuming ok.

> [drlvm][build] smoke tests run does not check exit code
> -------------------------------------------------------
>
>                 Key: HARMONY-3546
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3546
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Vladimir Beliaev
>            Assignee: Gregory Shimansky
>         Attachments: H3546.patch
>
>
> According to HARMONY-3527 (which is caused by committed patch from HARMONY-3065) the massive tests failures were expected.
> Still Curise Control shows the some tests passed fine. Accodring to done evaluation the test 'exit' code was not checked, so if test prints PASSED but returns 128 it was considered as passed.
> This should be fixed.
> While fixing one should note that smoke tests contain several tests which are supposed to exit with non-null value, namly:
> init.ErrorInInitializer, shutdown.TestFatalError, shutdown.TestInterrupt...
> I've attached the patch fixing the mensioned issue. BTW, it is uses ant "Variable" task for exit code redefinition for set of runs - might be better solution can be used here.
> While testing the patch I found the stress/Stack.java fails in JET mode. Still it is excluded in jit/srv/opt modes, it is also excluded for all jitrino modes for linux/em64t. So I've just updated X-list for JET (in the patch).
> Thanks
> Vladimir Beliaev

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3546) [drlvm][build] smoke tests run does not check exit code

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-3546.
----------------------------------------

    Resolution: Fixed

Patch applied at 525919. Please check that it was applied as expected.

> [drlvm][build] smoke tests run does not check exit code
> -------------------------------------------------------
>
>                 Key: HARMONY-3546
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3546
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Vladimir Beliaev
>         Assigned To: Gregory Shimansky
>         Attachments: H3546.patch
>
>
> According to HARMONY-3527 (which is caused by committed patch from HARMONY-3065) the massive tests failures were expected.
> Still Curise Control shows the some tests passed fine. Accodring to done evaluation the test 'exit' code was not checked, so if test prints PASSED but returns 128 it was considered as passed.
> This should be fixed.
> While fixing one should note that smoke tests contain several tests which are supposed to exit with non-null value, namly:
> init.ErrorInInitializer, shutdown.TestFatalError, shutdown.TestInterrupt...
> I've attached the patch fixing the mensioned issue. BTW, it is uses ant "Variable" task for exit code redefinition for set of runs - might be better solution can be used here.
> While testing the patch I found the stress/Stack.java fails in JET mode. Still it is excluded in jit/srv/opt modes, it is also excluded for all jitrino modes for linux/em64t. So I've just updated X-list for JET (in the patch).
> Thanks
> Vladimir Beliaev

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3546) [drlvm][build] smoke tests run does not check exit code

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-3546:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][build] smoke tests run does not check exit code
> -------------------------------------------------------
>
>                 Key: HARMONY-3546
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3546
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Vladimir Beliaev
>         Assigned To: Gregory Shimansky
>         Attachments: H3546.patch
>
>
> According to HARMONY-3527 (which is caused by committed patch from HARMONY-3065) the massive tests failures were expected.
> Still Curise Control shows the some tests passed fine. Accodring to done evaluation the test 'exit' code was not checked, so if test prints PASSED but returns 128 it was considered as passed.
> This should be fixed.
> While fixing one should note that smoke tests contain several tests which are supposed to exit with non-null value, namly:
> init.ErrorInInitializer, shutdown.TestFatalError, shutdown.TestInterrupt...
> I've attached the patch fixing the mensioned issue. BTW, it is uses ant "Variable" task for exit code redefinition for set of runs - might be better solution can be used here.
> While testing the patch I found the stress/Stack.java fails in JET mode. Still it is excluded in jit/srv/opt modes, it is also excluded for all jitrino modes for linux/em64t. So I've just updated X-list for JET (in the patch).
> Thanks
> Vladimir Beliaev

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.