[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes…

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes…
URL: https://github.com/apache/nifi-minifi-cpp/pull/601#discussion_r298573237
 
 

 ##########
 File path: extensions/standard-processors/tests/unit/TailFileTests.cpp
 ##########
 @@ -78,7 +78,245 @@ TEST_CASE("TailFileWithDelimiter", "[tailfiletest2]") {
 
   // Delete the test and state file.
   remove(TMP_FILE);
-  remove(STATE_FILE);
+  remove(std::string(std::string(STATE_FILE) + "." + id).c_str());
+}
+
+TEST_CASE("TestNewContent", "[tailFileWithDelimiterState]") {
 
 Review comment:
   There were testcases in this file already resetting plan and running TailFile multiple times, the only things they missed to verify this behaviour is the new flag you just added to clear configured processors. 
   
   More tests don't hurt anyway, so let's leave it as is, although modifying some of those testscases to verify state storing as well might be good, too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services