[kudu-CR] KUDU-3353 [schema] Add an immutable attribute on column schema (part 3)

["Yifan Zhang (Code Review)" <ge...@cloudera.org>]

Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18993 )

Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 3)
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18993/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18993/6//COMMIT_MSG@19
PS6, Line 19: hasNullableColumns
nit: Should it be 'hasImmutableColumns'?


http://gerrit.cloudera.org:8080/#/c/18993/6/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java:

http://gerrit.cloudera.org:8080/#/c/18993/6/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@488
PS6, Line 488: changeImmutable
nit: To be consistent with c++ API, maybe we can replace the method with 'setImmutable' and 'setMutable'?



-- 
To view, visit http://gerrit.cloudera.org:8080/18993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdfdcd123296803a3b5e856ec5eaac49c05b7f8d
Gerrit-Change-Number: 18993
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 04:41:08 +0000
Gerrit-HasComments: Yes