[GitHub] [airflow] jward-bw commented on a change in pull request #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record

[GitBox <gi...@apache.org>]

jward-bw commented on a change in pull request #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record
URL: https://github.com/apache/airflow/pull/7141#discussion_r373462956
 
 

 ##########
 File path: airflow/utils/log/es_task_handler.py
 ##########
 @@ -53,9 +53,12 @@ class ElasticsearchTaskHandler(FileTaskHandler, LoggingMixin):
     PAGE = 0
     MAX_LINE_PER_PAGE = 1000
 
+    # 16 is reasonable in this case
+    # pylint: disable-msg=too-many-arguments
     def __init__(self, base_log_folder, filename_template,
                  log_id_template, end_of_log_mark,
                  write_stdout, json_format, json_fields,
+                 index='*',
 
 Review comment:
   Just to check `*` will match all indexes? I am working with an ES cluster where we have a new index every day

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services