You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/07/30 18:29:04 UTC
git commit: [SPARK-2747] git diff --dirstat can miss sql changes and
not run Hive tests
Repository: spark
Updated Branches:
refs/heads/master 774142f55 -> 3bc3f1801
[SPARK-2747] git diff --dirstat can miss sql changes and not run Hive tests
dev/run-tests use "git diff --dirstat master" to check whether sql is changed. However, --dirstat won't show sql if sql's change is negligible (e.g. 1k loc change in core, and only 1 loc change in hive).
We should use "git diff --name-only master" instead.
Author: Reynold Xin <rx...@apache.org>
Closes #1656 from rxin/hiveTest and squashes the following commits:
f5eab9f [Reynold Xin] [SPARK-2747] git diff --dirstat can miss sql changes and not run Hive tests.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/3bc3f180
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/3bc3f180
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/3bc3f180
Branch: refs/heads/master
Commit: 3bc3f1801e3347e02cbecdd8e941003430155da2
Parents: 774142f
Author: Reynold Xin <rx...@apache.org>
Authored: Wed Jul 30 09:28:53 2014 -0700
Committer: Reynold Xin <rx...@apache.org>
Committed: Wed Jul 30 09:28:53 2014 -0700
----------------------------------------------------------------------
dev/run-tests | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/3bc3f180/dev/run-tests
----------------------------------------------------------------------
diff --git a/dev/run-tests b/dev/run-tests
index 98ec969..795d16a 100755
--- a/dev/run-tests
+++ b/dev/run-tests
@@ -37,7 +37,7 @@ JAVA_VERSION=$($java_cmd -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..*
# Partial solution for SPARK-1455. Only run Hive tests if there are sql changes.
if [ -n "$AMPLAB_JENKINS" ]; then
git fetch origin master:master
- diffs=`git diff --dirstat master | awk '{ print $2; }' | grep "^sql/"`
+ diffs=`git diff --name-only master | grep "^sql/"`
if [ -n "$diffs" ]; then
echo "Detected changes in SQL. Will run Hive test suite."
export _RUN_SQL_TESTS=true # exported for PySpark tests