You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2014/12/14 08:08:20 UTC
git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act
to list of files to copy
Repository: flex-sdk
Updated Branches:
refs/heads/release4.14.0 666177514 -> 743748429
add adl and act to list of files to copy
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/74374842
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/74374842
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/74374842
Branch: refs/heads/release4.14.0
Commit: 743748429f1f0773a9edc6464abb5bc41db1f4d7
Parents: 6661775
Author: Justin Mclean <jm...@apache.org>
Authored: Sun Dec 14 18:07:57 2014 +1100
Committer: Justin Mclean <jm...@apache.org>
Committed: Sun Dec 14 18:07:57 2014 +1100
----------------------------------------------------------------------
ide/constructFlexForIDE.sh | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/74374842/ide/constructFlexForIDE.sh
----------------------------------------------------------------------
diff --git a/ide/constructFlexForIDE.sh b/ide/constructFlexForIDE.sh
index 1d1af97..d9533ab 100755
--- a/ide/constructFlexForIDE.sh
+++ b/ide/constructFlexForIDE.sh
@@ -155,6 +155,8 @@ files=(
"AIR SDK Readme.txt"
bin/adl.exe
bin/adt.bat
+ bin/adl
+ bin/adt
frameworks/libs/air
frameworks/libs/player/11.1
frameworks/projects/air
RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Chris Martin <ch...@outlook.com>.
Okay, committed to release4.14.0 branch. Will need someone with a Mac to give the script a test. Basically just make sure adl and adt are present in the target framework's bin folder. And that adl.exe and adt.bat are not present.
Chris
> From: erik@ixsoftware.nl
> Date: Thu, 18 Dec 2014 08:52:36 +0100
> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> To: dev@flex.apache.org
>
> Chris,
>
> Just commit to the 'release4.14' branch. I'll merge that back into
> develop when we've released (or maybe sooner, if my time permits).
>
> Thanks,
>
> EdB
>
>
>
> On Wed, Dec 17, 2014 at 10:44 PM, Chris Martin <ch...@outlook.com> wrote:
> >
> >
> >
> > Okay, I got a change to the script that will detect the OS. Basically it will look for linux emulated in windows (CYGWIN and MINGW), if one of those are detected, then it will choose a file set for that environment to copy (basically the adl.exe and adt.bat. If it detects any other environment then it will assume it is a unix environment and copy a file set that includes adt and adl instead. Should I just commit this change against the head, or would it be best to commit it against Justin's and then merge it into the head? I'm leaning towards merging it in as it will keep the change together as we try to address the missing adt and adl issue.
> >
> > Chris
> >
> >> From: chrsmrtn@outlook.com
> >> To: dev@flex.apache.org
> >> Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> >> Date: Tue, 16 Dec 2014 14:22:41 -0700
> >>
> >> Ugh, one test and it worked, and now the other it is not. The -n file is not clobbering the file as noted in the help, but the error is still being presented and the script stops.
> >>
> >> Chris
> >>
> >> > From: chrsmrtn@outlook.com
> >> > To: dev@flex.apache.org
> >> > Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> >> > Date: Tue, 16 Dec 2014 14:04:57 -0700
> >> >
> >> > Yeah, we can use uname[1]. I try my best to avoid OS detection only because there are many out there. This issue stems from how .exe files are handled in Cygwin. Basically they treat 'file.exe' and 'file' to be the same thing as 'file' is an executable in *nix[2].
> >> >
> >> > Judging by how the rsync command uses --ignore-existing (skip updating files that already exist on receiver), then would it be right to assume that cp is to behave the same way? Basically only copy over files if they don't already exist in the target sdk folder. I'm basing my assuming on yes only because that is what will happen if we copy over a directory, existing files will not be overwritten and skipped. If we do intend to skip existing files then we just need to add the -n flag to the cp command at line 68 (inside copyFileOrDirectory). After that we will not attempt to copy adl if adl.exe already exists in the target sdk folder.
> >> >
> >> > Chris
> >> >
> >> >
> >> > [1] http://en.wikipedia.org/wiki/Uname
> >> > [2] http://cygwin.1069669.n5.nabble.com/cp-utility-bug-when-dest-name-exe-file-exist-tp57955p58001.html
> >> >
> >> > > From: erik@ixsoftware.nl
> >> > > Date: Tue, 16 Dec 2014 19:00:40 +0100
> >> > > Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> >> > > To: dev@flex.apache.org
> >> > >
> >> > > Do you have any idea how we may special case the copy of these files,
> >> > > so they are excluded when the script runs on Cygwin?
> >> > >
> >> > > EdB
> >> > >
> >> > >
> >> > >
> >> > > On Tue, Dec 16, 2014 at 6:46 PM, Chris Martin <ch...@outlook.com> wrote:
> >> > > > Hey everyone,
> >> > > >
> >> > > > The original shell file ran fine on Cygwin.
> >> > > >
> >> > > > Chris
> >> > > >
> >> > > >> From: erik@ixsoftware.nl
> >> > > >> Date: Tue, 16 Dec 2014 17:05:35 +0100
> >> > > >> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> >> > > >> To: dev@flex.apache.org
> >> > > >>
> >> > > >> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
> >> > > >>
> >> > > >> No, I think we aren't expecting that. *.bat only runs on Windows, so
> >> > > >> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
> >> > > >> AND Windows (Cygwin), so it needs to copy both the exe and the other
> >> > > >> files, which Justin added...
> >> > > >>
> >> > > >> If the original file ran well on Cygwin, and the new file runs into
> >> > > >> problems, I think we need to revert the lines Justin added and try to
> >> > > >> figure out a way to make those two copy commands conditional to the
> >> > > >> platform (i.e. not run on Cygwin).
> >> > > >>
> >> > > >> EdB
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> --
> >> > > >> Ix Multimedia Software
> >> > > >>
> >> > > >> Jan Luykenstraat 27
> >> > > >> 3521 VB Utrecht
> >> > > >>
> >> > > >> T. 06-51952295
> >> > > >> I. www.ixsoftware.nl
> >> > > >
> >> > >
> >> > >
> >> > >
> >> > > --
> >> > > Ix Multimedia Software
> >> > >
> >> > > Jan Luykenstraat 27
> >> > > 3521 VB Utrecht
> >> > >
> >> > > T. 06-51952295
> >> > > I. www.ixsoftware.nl
> >> >
> >>
> >
> >
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Chris,
Just commit to the 'release4.14' branch. I'll merge that back into
develop when we've released (or maybe sooner, if my time permits).
Thanks,
EdB
On Wed, Dec 17, 2014 at 10:44 PM, Chris Martin <ch...@outlook.com> wrote:
>
>
>
> Okay, I got a change to the script that will detect the OS. Basically it will look for linux emulated in windows (CYGWIN and MINGW), if one of those are detected, then it will choose a file set for that environment to copy (basically the adl.exe and adt.bat. If it detects any other environment then it will assume it is a unix environment and copy a file set that includes adt and adl instead. Should I just commit this change against the head, or would it be best to commit it against Justin's and then merge it into the head? I'm leaning towards merging it in as it will keep the change together as we try to address the missing adt and adl issue.
>
> Chris
>
>> From: chrsmrtn@outlook.com
>> To: dev@flex.apache.org
>> Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
>> Date: Tue, 16 Dec 2014 14:22:41 -0700
>>
>> Ugh, one test and it worked, and now the other it is not. The -n file is not clobbering the file as noted in the help, but the error is still being presented and the script stops.
>>
>> Chris
>>
>> > From: chrsmrtn@outlook.com
>> > To: dev@flex.apache.org
>> > Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
>> > Date: Tue, 16 Dec 2014 14:04:57 -0700
>> >
>> > Yeah, we can use uname[1]. I try my best to avoid OS detection only because there are many out there. This issue stems from how .exe files are handled in Cygwin. Basically they treat 'file.exe' and 'file' to be the same thing as 'file' is an executable in *nix[2].
>> >
>> > Judging by how the rsync command uses --ignore-existing (skip updating files that already exist on receiver), then would it be right to assume that cp is to behave the same way? Basically only copy over files if they don't already exist in the target sdk folder. I'm basing my assuming on yes only because that is what will happen if we copy over a directory, existing files will not be overwritten and skipped. If we do intend to skip existing files then we just need to add the -n flag to the cp command at line 68 (inside copyFileOrDirectory). After that we will not attempt to copy adl if adl.exe already exists in the target sdk folder.
>> >
>> > Chris
>> >
>> >
>> > [1] http://en.wikipedia.org/wiki/Uname
>> > [2] http://cygwin.1069669.n5.nabble.com/cp-utility-bug-when-dest-name-exe-file-exist-tp57955p58001.html
>> >
>> > > From: erik@ixsoftware.nl
>> > > Date: Tue, 16 Dec 2014 19:00:40 +0100
>> > > Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
>> > > To: dev@flex.apache.org
>> > >
>> > > Do you have any idea how we may special case the copy of these files,
>> > > so they are excluded when the script runs on Cygwin?
>> > >
>> > > EdB
>> > >
>> > >
>> > >
>> > > On Tue, Dec 16, 2014 at 6:46 PM, Chris Martin <ch...@outlook.com> wrote:
>> > > > Hey everyone,
>> > > >
>> > > > The original shell file ran fine on Cygwin.
>> > > >
>> > > > Chris
>> > > >
>> > > >> From: erik@ixsoftware.nl
>> > > >> Date: Tue, 16 Dec 2014 17:05:35 +0100
>> > > >> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
>> > > >> To: dev@flex.apache.org
>> > > >>
>> > > >> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
>> > > >>
>> > > >> No, I think we aren't expecting that. *.bat only runs on Windows, so
>> > > >> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
>> > > >> AND Windows (Cygwin), so it needs to copy both the exe and the other
>> > > >> files, which Justin added...
>> > > >>
>> > > >> If the original file ran well on Cygwin, and the new file runs into
>> > > >> problems, I think we need to revert the lines Justin added and try to
>> > > >> figure out a way to make those two copy commands conditional to the
>> > > >> platform (i.e. not run on Cygwin).
>> > > >>
>> > > >> EdB
>> > > >>
>> > > >>
>> > > >>
>> > > >> --
>> > > >> Ix Multimedia Software
>> > > >>
>> > > >> Jan Luykenstraat 27
>> > > >> 3521 VB Utrecht
>> > > >>
>> > > >> T. 06-51952295
>> > > >> I. www.ixsoftware.nl
>> > > >
>> > >
>> > >
>> > >
>> > > --
>> > > Ix Multimedia Software
>> > >
>> > > Jan Luykenstraat 27
>> > > 3521 VB Utrecht
>> > >
>> > > T. 06-51952295
>> > > I. www.ixsoftware.nl
>> >
>>
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Chris Martin <ch...@outlook.com>.
Okay, I got a change to the script that will detect the OS. Basically it will look for linux emulated in windows (CYGWIN and MINGW), if one of those are detected, then it will choose a file set for that environment to copy (basically the adl.exe and adt.bat. If it detects any other environment then it will assume it is a unix environment and copy a file set that includes adt and adl instead. Should I just commit this change against the head, or would it be best to commit it against Justin's and then merge it into the head? I'm leaning towards merging it in as it will keep the change together as we try to address the missing adt and adl issue.
Chris
> From: chrsmrtn@outlook.com
> To: dev@flex.apache.org
> Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> Date: Tue, 16 Dec 2014 14:22:41 -0700
>
> Ugh, one test and it worked, and now the other it is not. The -n file is not clobbering the file as noted in the help, but the error is still being presented and the script stops.
>
> Chris
>
> > From: chrsmrtn@outlook.com
> > To: dev@flex.apache.org
> > Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> > Date: Tue, 16 Dec 2014 14:04:57 -0700
> >
> > Yeah, we can use uname[1]. I try my best to avoid OS detection only because there are many out there. This issue stems from how .exe files are handled in Cygwin. Basically they treat 'file.exe' and 'file' to be the same thing as 'file' is an executable in *nix[2].
> >
> > Judging by how the rsync command uses --ignore-existing (skip updating files that already exist on receiver), then would it be right to assume that cp is to behave the same way? Basically only copy over files if they don't already exist in the target sdk folder. I'm basing my assuming on yes only because that is what will happen if we copy over a directory, existing files will not be overwritten and skipped. If we do intend to skip existing files then we just need to add the -n flag to the cp command at line 68 (inside copyFileOrDirectory). After that we will not attempt to copy adl if adl.exe already exists in the target sdk folder.
> >
> > Chris
> >
> >
> > [1] http://en.wikipedia.org/wiki/Uname
> > [2] http://cygwin.1069669.n5.nabble.com/cp-utility-bug-when-dest-name-exe-file-exist-tp57955p58001.html
> >
> > > From: erik@ixsoftware.nl
> > > Date: Tue, 16 Dec 2014 19:00:40 +0100
> > > Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> > > To: dev@flex.apache.org
> > >
> > > Do you have any idea how we may special case the copy of these files,
> > > so they are excluded when the script runs on Cygwin?
> > >
> > > EdB
> > >
> > >
> > >
> > > On Tue, Dec 16, 2014 at 6:46 PM, Chris Martin <ch...@outlook.com> wrote:
> > > > Hey everyone,
> > > >
> > > > The original shell file ran fine on Cygwin.
> > > >
> > > > Chris
> > > >
> > > >> From: erik@ixsoftware.nl
> > > >> Date: Tue, 16 Dec 2014 17:05:35 +0100
> > > >> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> > > >> To: dev@flex.apache.org
> > > >>
> > > >> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
> > > >>
> > > >> No, I think we aren't expecting that. *.bat only runs on Windows, so
> > > >> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
> > > >> AND Windows (Cygwin), so it needs to copy both the exe and the other
> > > >> files, which Justin added...
> > > >>
> > > >> If the original file ran well on Cygwin, and the new file runs into
> > > >> problems, I think we need to revert the lines Justin added and try to
> > > >> figure out a way to make those two copy commands conditional to the
> > > >> platform (i.e. not run on Cygwin).
> > > >>
> > > >> EdB
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> Ix Multimedia Software
> > > >>
> > > >> Jan Luykenstraat 27
> > > >> 3521 VB Utrecht
> > > >>
> > > >> T. 06-51952295
> > > >> I. www.ixsoftware.nl
> > > >
> > >
> > >
> > >
> > > --
> > > Ix Multimedia Software
> > >
> > > Jan Luykenstraat 27
> > > 3521 VB Utrecht
> > >
> > > T. 06-51952295
> > > I. www.ixsoftware.nl
> >
>
RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Chris Martin <ch...@outlook.com>.
Ugh, one test and it worked, and now the other it is not. The -n file is not clobbering the file as noted in the help, but the error is still being presented and the script stops.
Chris
> From: chrsmrtn@outlook.com
> To: dev@flex.apache.org
> Subject: RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> Date: Tue, 16 Dec 2014 14:04:57 -0700
>
> Yeah, we can use uname[1]. I try my best to avoid OS detection only because there are many out there. This issue stems from how .exe files are handled in Cygwin. Basically they treat 'file.exe' and 'file' to be the same thing as 'file' is an executable in *nix[2].
>
> Judging by how the rsync command uses --ignore-existing (skip updating files that already exist on receiver), then would it be right to assume that cp is to behave the same way? Basically only copy over files if they don't already exist in the target sdk folder. I'm basing my assuming on yes only because that is what will happen if we copy over a directory, existing files will not be overwritten and skipped. If we do intend to skip existing files then we just need to add the -n flag to the cp command at line 68 (inside copyFileOrDirectory). After that we will not attempt to copy adl if adl.exe already exists in the target sdk folder.
>
> Chris
>
>
> [1] http://en.wikipedia.org/wiki/Uname
> [2] http://cygwin.1069669.n5.nabble.com/cp-utility-bug-when-dest-name-exe-file-exist-tp57955p58001.html
>
> > From: erik@ixsoftware.nl
> > Date: Tue, 16 Dec 2014 19:00:40 +0100
> > Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> > To: dev@flex.apache.org
> >
> > Do you have any idea how we may special case the copy of these files,
> > so they are excluded when the script runs on Cygwin?
> >
> > EdB
> >
> >
> >
> > On Tue, Dec 16, 2014 at 6:46 PM, Chris Martin <ch...@outlook.com> wrote:
> > > Hey everyone,
> > >
> > > The original shell file ran fine on Cygwin.
> > >
> > > Chris
> > >
> > >> From: erik@ixsoftware.nl
> > >> Date: Tue, 16 Dec 2014 17:05:35 +0100
> > >> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> > >> To: dev@flex.apache.org
> > >>
> > >> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
> > >>
> > >> No, I think we aren't expecting that. *.bat only runs on Windows, so
> > >> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
> > >> AND Windows (Cygwin), so it needs to copy both the exe and the other
> > >> files, which Justin added...
> > >>
> > >> If the original file ran well on Cygwin, and the new file runs into
> > >> problems, I think we need to revert the lines Justin added and try to
> > >> figure out a way to make those two copy commands conditional to the
> > >> platform (i.e. not run on Cygwin).
> > >>
> > >> EdB
> > >>
> > >>
> > >>
> > >> --
> > >> Ix Multimedia Software
> > >>
> > >> Jan Luykenstraat 27
> > >> 3521 VB Utrecht
> > >>
> > >> T. 06-51952295
> > >> I. www.ixsoftware.nl
> > >
> >
> >
> >
> > --
> > Ix Multimedia Software
> >
> > Jan Luykenstraat 27
> > 3521 VB Utrecht
> >
> > T. 06-51952295
> > I. www.ixsoftware.nl
>
RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Chris Martin <ch...@outlook.com>.
Yeah, we can use uname[1]. I try my best to avoid OS detection only because there are many out there. This issue stems from how .exe files are handled in Cygwin. Basically they treat 'file.exe' and 'file' to be the same thing as 'file' is an executable in *nix[2].
Judging by how the rsync command uses --ignore-existing (skip updating files that already exist on receiver), then would it be right to assume that cp is to behave the same way? Basically only copy over files if they don't already exist in the target sdk folder. I'm basing my assuming on yes only because that is what will happen if we copy over a directory, existing files will not be overwritten and skipped. If we do intend to skip existing files then we just need to add the -n flag to the cp command at line 68 (inside copyFileOrDirectory). After that we will not attempt to copy adl if adl.exe already exists in the target sdk folder.
Chris
[1] http://en.wikipedia.org/wiki/Uname
[2] http://cygwin.1069669.n5.nabble.com/cp-utility-bug-when-dest-name-exe-file-exist-tp57955p58001.html
> From: erik@ixsoftware.nl
> Date: Tue, 16 Dec 2014 19:00:40 +0100
> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> To: dev@flex.apache.org
>
> Do you have any idea how we may special case the copy of these files,
> so they are excluded when the script runs on Cygwin?
>
> EdB
>
>
>
> On Tue, Dec 16, 2014 at 6:46 PM, Chris Martin <ch...@outlook.com> wrote:
> > Hey everyone,
> >
> > The original shell file ran fine on Cygwin.
> >
> > Chris
> >
> >> From: erik@ixsoftware.nl
> >> Date: Tue, 16 Dec 2014 17:05:35 +0100
> >> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> >> To: dev@flex.apache.org
> >>
> >> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
> >>
> >> No, I think we aren't expecting that. *.bat only runs on Windows, so
> >> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
> >> AND Windows (Cygwin), so it needs to copy both the exe and the other
> >> files, which Justin added...
> >>
> >> If the original file ran well on Cygwin, and the new file runs into
> >> problems, I think we need to revert the lines Justin added and try to
> >> figure out a way to make those two copy commands conditional to the
> >> platform (i.e. not run on Cygwin).
> >>
> >> EdB
> >>
> >>
> >>
> >> --
> >> Ix Multimedia Software
> >>
> >> Jan Luykenstraat 27
> >> 3521 VB Utrecht
> >>
> >> T. 06-51952295
> >> I. www.ixsoftware.nl
> >
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Do you have any idea how we may special case the copy of these files,
so they are excluded when the script runs on Cygwin?
EdB
On Tue, Dec 16, 2014 at 6:46 PM, Chris Martin <ch...@outlook.com> wrote:
> Hey everyone,
>
> The original shell file ran fine on Cygwin.
>
> Chris
>
>> From: erik@ixsoftware.nl
>> Date: Tue, 16 Dec 2014 17:05:35 +0100
>> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
>> To: dev@flex.apache.org
>>
>> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
>>
>> No, I think we aren't expecting that. *.bat only runs on Windows, so
>> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
>> AND Windows (Cygwin), so it needs to copy both the exe and the other
>> files, which Justin added...
>>
>> If the original file ran well on Cygwin, and the new file runs into
>> problems, I think we need to revert the lines Justin added and try to
>> figure out a way to make those two copy commands conditional to the
>> platform (i.e. not run on Cygwin).
>>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Chris Martin <ch...@outlook.com>.
Hey everyone,
The original shell file ran fine on Cygwin.
Chris
> From: erik@ixsoftware.nl
> Date: Tue, 16 Dec 2014 17:05:35 +0100
> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> To: dev@flex.apache.org
>
> > Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
>
> No, I think we aren't expecting that. *.bat only runs on Windows, so
> only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
> AND Windows (Cygwin), so it needs to copy both the exe and the other
> files, which Justin added...
>
> If the original file ran well on Cygwin, and the new file runs into
> problems, I think we need to revert the lines Justin added and try to
> figure out a way to make those two copy commands conditional to the
> platform (i.e. not run on Cygwin).
>
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Erik de Bruin <er...@ixsoftware.nl>.
> Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
No, I think we aren't expecting that. *.bat only runs on Windows, so
only needs to copy the adt.exe and adl.exe. the *.sh can run on Mac
AND Windows (Cygwin), so it needs to copy both the exe and the other
files, which Justin added...
If the original file ran well on Cygwin, and the new file runs into
problems, I think we need to revert the lines Justin added and try to
figure out a way to make those two copy commands conditional to the
platform (i.e. not run on Cygwin).
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
RE: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Chris Martin <ch...@outlook.com>.
> I'm not 100% sure that the script worked before on cygwin, could someone check?
*raises his hand* I'll take a peek.
Also wanted to make sure it was noted that the bat file also does not copy the adt and adl files as I think we are expecting. Are we expecting those files to also be copied if they use the bat file?
Chris
> From: jmclean@apache.org
> Subject: Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
> Date: Tue, 16 Dec 2014 18:13:38 +1100
> To: dev@flex.apache.org
>
> Hi,
>
> > This change seems to have created an issue on Windows, using Cygwin.
>
> I'm not 100% sure that the script worked before on cygwin, could someone check? While it might be nice if that script worked in cygwin it's not IMO a release blocker. If possible can someone who has that environment set up help out here.
>
> Thanks,
> Justin
Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and act to list of files to copy
Posted by Justin Mclean <jm...@apache.org>.
Hi,
> This change seems to have created an issue on Windows, using Cygwin.
I'm not 100% sure that the script worked before on cygwin, could someone check? While it might be nice if that script worked in cygwin it's not IMO a release blocker. If possible can someone who has that environment set up help out here.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - add adl and
act to list of files to copy
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Hi Justin,
This change seems to have created an issue on Windows, using Cygwin.
Can you please address the issue raised in Chris M's email in the
'missing adl on Mac' thread?
Thanks,
EdB
On Sun, Dec 14, 2014 at 8:08 AM, <jm...@apache.org> wrote:
> Repository: flex-sdk
> Updated Branches:
> refs/heads/release4.14.0 666177514 -> 743748429
>
>
> add adl and act to list of files to copy
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/74374842
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/74374842
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/74374842
>
> Branch: refs/heads/release4.14.0
> Commit: 743748429f1f0773a9edc6464abb5bc41db1f4d7
> Parents: 6661775
> Author: Justin Mclean <jm...@apache.org>
> Authored: Sun Dec 14 18:07:57 2014 +1100
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Sun Dec 14 18:07:57 2014 +1100
>
> ----------------------------------------------------------------------
> ide/constructFlexForIDE.sh | 2 ++
> 1 file changed, 2 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/74374842/ide/constructFlexForIDE.sh
> ----------------------------------------------------------------------
> diff --git a/ide/constructFlexForIDE.sh b/ide/constructFlexForIDE.sh
> index 1d1af97..d9533ab 100755
> --- a/ide/constructFlexForIDE.sh
> +++ b/ide/constructFlexForIDE.sh
> @@ -155,6 +155,8 @@ files=(
> "AIR SDK Readme.txt"
> bin/adl.exe
> bin/adt.bat
> + bin/adl
> + bin/adt
> frameworks/libs/air
> frameworks/libs/player/11.1
> frameworks/projects/air
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl