You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2014/05/17 18:03:14 UTC

[jira] [Commented] (CASSANDRA-7244) Don't allocate a Codec.Flag enum value array on every read

    [ https://issues.apache.org/jira/browse/CASSANDRA-7244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000811#comment-14000811 ] 

Dave Brosius commented on CASSANDRA-7244:
-----------------------------------------

+1

> Don't allocate a Codec.Flag enum value array on every read
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-7244
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7244
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>              Labels: performance
>             Fix For: 2.1 rc1
>
>         Attachments: 7244.txt
>
>
> In QueryOptions.Codec.Flag.deserialize() we call Flag.values(), which constructs a copy of the Enum array each time. Since we only use this lookup the enums, and since it happens _often_, this is pretty wasteful. It seems to make a slight (barely perceptible) difference to throughput, but worth fixing either way.



--
This message was sent by Atlassian JIRA
(v6.2#6252)