[jira] [Commented] (FLINK-13353) wrong definition of Replace planner expression

["Louis Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890008#comment-16890008 ] 

Louis Xu commented on FLINK-13353:
----------------------------------

[~jark] [~lzljs3620320] What do you think? And how about assign this issue to me? Thanks.

> wrong definition of Replace planner expression
> ----------------------------------------------
>
>                 Key: FLINK-13353
>                 URL: https://issues.apache.org/jira/browse/FLINK-13353
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Louis Xu
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Replace definition in stringExpression.scala has another constructor with 2 arguments.
> According to source code, the args' meaning are str, begin. And it call other constructor with 3 args adding the 3rd arg which is the length of str.
> But its expectTypes is (String, String, String), but actually is (String, int, int).
> So I think the 2 args defined constructor means search and replacement is "" default, not begin and length of str. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)