[GitHub] geode pull request #475: GEODE-2812: Add API to get list of live locators

[kirklund <gi...@git.apache.org>]

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/475#discussion_r114674811
  
    --- Diff: geode-core/src/main/java/org/apache/geode/cache/client/Pool.java ---
    @@ -193,13 +193,23 @@
       /**
        * Returns an unmodifiable list of {@link java.net.InetSocketAddress} of the locators this pool is
        * using. Each locator is either one {@link PoolFactory#addLocator added explicitly} when the pool
    -   * was created or were discovered using the explicit locators.
    +   * was created.
        * <p>
        * If a pool has no locators then it can not discover servers or locators at runtime.
        */
       public java.util.List<InetSocketAddress> getLocators();
     
       /**
    +   * Returns an unmodifiable list of {@link java.net.InetSocketAddress} of the locators this pool is
    +   * using. The returned locator is only the currently living locator found based on the periodic
    +   * locator list request.
    +   * <p>
    +   * The returned locator list may be slightly old information. If the locator does not exist, an
    +   * empty list is returned.
    +   */
    +  public java.util.List<InetSocketAddress> getLiveLocators();
    --- End diff --
    
    We usually use the terms "online" vs "offline" to distinguish between a member or server that's currently running or not. I would recommend changing from "live" to "online":
    ```java
    List<InetSocketAddress> getOnlineLocators();
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---