You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2017/11/30 13:50:56 UTC

Review Request 64210: ATLAS-2281 : Saving Tag/Type attribute filter queries with null/not null filters.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64210/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2281
    https://issues.apache.org/jira/browse/ATLAS-2281


Repository: atlas


Description
-------

1. Fired Basic Search 
   typename = hive_table , 
   filter : "Name" condition : "is not null".
2. Saved the query.
3. Executed the saved query which fetched all the correct tables.
4. Now to modify the search , clicked on the saved search and clicked on the type filter. 
5. The Attribute filter window didn't load.
 " Error: Undefined operator "notNull" " was thrown in browser's console logs.

Same happens when clicking the saved search containing "is null" filter. "Error: Undefined operator "isNull" " is thrown in console.log. But the saved search can be executed without any issues. 

Also seen in tag attributes filters.


Diffs
-----

  dashboardv2/public/js/utils/CommonViewFunction.js a3b6b91 


Diff: https://reviews.apache.org/r/64210/diff/1/


Testing
-------

Done one round of sanity testing


Thanks,

pratik pandey

Re: Review Request 64210: ATLAS-2281 : Saving Tag/Type attribute filter queries with null/not null filters.

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64210/#review192311
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 30, 2017, 1:50 p.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64210/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 1:50 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2281
>     https://issues.apache.org/jira/browse/ATLAS-2281
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. Fired Basic Search 
>    typename = hive_table , 
>    filter : "Name" condition : "is not null".
> 2. Saved the query.
> 3. Executed the saved query which fetched all the correct tables.
> 4. Now to modify the search , clicked on the saved search and clicked on the type filter. 
> 5. The Attribute filter window didn't load.
>  " Error: Undefined operator "notNull" " was thrown in browser's console logs.
> 
> Same happens when clicking the saved search containing "is null" filter. "Error: Undefined operator "isNull" " is thrown in console.log. But the saved search can be executed without any issues. 
> 
> Also seen in tag attributes filters.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js a3b6b91 
> 
> 
> Diff: https://reviews.apache.org/r/64210/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing
> 
> 
> Thanks,
> 
> pratik pandey
> 
>