You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/04 08:39:29 UTC
[GitHub] [spark] zhengruifeng opened a new pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
zhengruifeng opened a new pull request #31469:
URL: https://github.com/apache/spark/pull/31469
### What changes were proposed in this pull request?
Param Validation throw `IllegalArgumentException`
### Why are the changes needed?
Param Validation should throw `IllegalArgumentException` instead of `IllegalStateException`
### Does this PR introduce _any_ user-facing change?
Yes, the type of exception changed
### How was this patch tested?
existing testsuites
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #31469:
URL: https://github.com/apache/spark/pull/31469
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773148826
**[Test build #134864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134864/testReport)** for PR 31469 at commit [`40a9a53`](https://github.com/apache/spark/commit/40a9a539971ed3755c3e2f237c87a57425415e54).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773189276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773188631
**[Test build #134864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134864/testReport)** for PR 31469 at commit [`40a9a53`](https://github.com/apache/spark/commit/40a9a539971ed3755c3e2f237c87a57425415e54).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773188484
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39452/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773133202
ping @huaxingao @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773148826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773148826
**[Test build #134864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134864/testReport)** for PR 31469 at commit [`40a9a53`](https://github.com/apache/spark/commit/40a9a539971ed3755c3e2f237c87a57425415e54).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773739011
merged to master, thanks all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #31469:
URL: https://github.com/apache/spark/pull/31469
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773222380
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39452/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773222380
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39452/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773133202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773189276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773189276
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134864/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773209423
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39452/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773189276
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134864/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31469: [MINOR][ML] Param Validation should throw IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773148826
**[Test build #134864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134864/testReport)** for PR 31469 at commit [`40a9a53`](https://github.com/apache/spark/commit/40a9a539971ed3755c3e2f237c87a57425415e54).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org