You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2011/04/24 15:47:05 UTC
[jira] [Created] (ZOOKEEPER-1052) Findbugs warning in
QuorumPeer.ResponderThread.run()
Findbugs warning in QuorumPeer.ResponderThread.run()
----------------------------------------------------
Key: ZOOKEEPER-1052
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1052
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.3.2
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.4.0
{noformat}
REC Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run()
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1052) Findbugs warning in
QuorumPeer.ResponderThread.run()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024628#comment-13024628 ]
Hadoop QA commented on ZOOKEEPER-1052:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477244/ZOOKEEPER-1052.patch
against trunk revision 1091841.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//console
This message is automatically generated.
> Findbugs warning in QuorumPeer.ResponderThread.run()
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1052
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1052
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.3.2
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1052.patch
>
>
> {noformat}
> REC Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run()
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1052) Findbugs warning in
QuorumPeer.ResponderThread.run()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028702#comment-13028702 ]
Hudson commented on ZOOKEEPER-1052:
-----------------------------------
Integrated in ZooKeeper-trunk #1172 (See [https://builds.apache.org/hudson/job/ZooKeeper-trunk/1172/])
ZOOKEEPER-1052. Findbugs warning in QuorumPeer.ResponderThread.run() (fpj via michim)
> Findbugs warning in QuorumPeer.ResponderThread.run()
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1052
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1052
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.3.2
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1052.patch
>
>
> {noformat}
> REC Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run()
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1052) Findbugs warning in
QuorumPeer.ResponderThread.run()
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027981#comment-13027981 ]
Michi Mutsuzaki commented on ZOOKEEPER-1052:
--------------------------------------------
+1
The patch looks good. Would it be ok if I go ahead and check this in, or should I wait for one more person to review it?
Thanks!
--Michi
> Findbugs warning in QuorumPeer.ResponderThread.run()
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1052
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1052
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.3.2
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1052.patch
>
>
> {noformat}
> REC Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run()
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1052) Findbugs warning in
QuorumPeer.ResponderThread.run()
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated ZOOKEEPER-1052:
----------------------------------------
Attachment: ZOOKEEPER-1052.patch
This patch splits the previous Exception into IOException and RuntimeException. We need to catch IOException, since it is thrown inside the block, and we also want to catch RuntimeExceptions so that we can warn an operator about the responder thread dying. Findbugs does not like having a block catching exception.
> Findbugs warning in QuorumPeer.ResponderThread.run()
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1052
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1052
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.3.2
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1052.patch
>
>
> {noformat}
> REC Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run()
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira