You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 19:47:20 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4714: Cleaning up code and enhancing a few IP management logs
GabrielBrascher opened a new pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714
### Description
This PR removes some unnecessary code and enhances a few log messages at IpAddressManagerImpl.
Additionally, method `com.cloud.network.NetworkModelImpl.areServicesEnabledInZone` does not use list `checkedProvider`; the respective list should either be removed or populated.
I have chosen to add provider names at `checkedProvider`, instead of removing it; however, I would appreciate any opinion/suggestion.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-840688754
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869734998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-834497036
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-834343030
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-837277395
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#discussion_r658998358
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -1124,15 +1124,18 @@ public boolean applyIpAssociations(Network network, boolean postApplyRules, bool
return success;
}
+ private String generateErrorMessageForOperationOnDisabledZone(String operation, DataCenter zone) {
+ return String.format("Cannot %s, %s is currently disabled.", operation, zone);
+ }
+
@DB
@Override
public AcquirePodIpCmdResponse allocatePodIp(String zoneId, String podId) throws ConcurrentOperationException, ResourceAllocationException {
DataCenter zone = _entityMgr.findByUuid(DataCenter.class, zoneId);
Account caller = CallContext.current().getCallingAccount();
if (Grouping.AllocationState.Disabled == zone.getAllocationState() && !_accountMgr.isRootAdmin(caller.getId())) {
- ResourceAllocationException ex = new ResourceAllocationException("Cannot perform this operation, " + "Zone is currently disabled" + "zoneId=" + zone.getUuid(),
- ResourceType.network);
+ ResourceAllocationException ex = new ResourceAllocationException(generateErrorMessageForOperationOnDisabledZone("allocate Pod IP addresses", zone), ResourceType.network);
Review comment:
Good observation; updated code breaking line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-868785444
<b>Trillian test result (tid-1100)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37539 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4714-t1100-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869189786
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-834342062
Conflicts have been fixed.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-824262462
A conflict has emerged, I will reserve some time to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869734998
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-889113383
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-841089149
<b>Trillian test result (tid-684)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43618 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4714-t684-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 85 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 15.31 | test_diagnostics.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 285.52 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 537.24 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 505.04 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 500.22 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-839142524
<b>Trillian test result (tid-630)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 127752 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4714-t630-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 52 look OK, 36 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 4.03 | test_accounts.py
test_forceDeleteDomain | `Failure` | 4.02 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.02 | test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.38 | test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.37 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.37 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 67.39 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 67.39 | test_iso.py
test_01_create_iso | `Failure` | 1513.26 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3024.96 | test_iso.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_list_clusters_metrics | `Error` | 1513.89 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.14 | test_metrics_api.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
test_delete_account | `Error` | 1517.91 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.11 | test_network.py
test_deploy_vm_l2network | `Error` | 1.10 | test_network.py
test_l2network_restart | `Error` | 2.17 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.31 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 1.04 | test_network.py
test_reboot_router | `Failure` | 0.03 | test_network.py
test_releaseIP | `Error` | 0.42 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.46 | test_network.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1517.40 | test_domain_service_offerings.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 120.82 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Error` | 1511.55 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1522.55 | test_projects.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.11 | test_service_offerings.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.42 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.61 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.38 | test_templates.py
test_04_extract_template | `Failure` | 128.50 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_10_attachAndDetach_iso | `Failure` | 1513.00 | test_vm_life_cycle.py
test_06_download_detached_volume | `Failure` | 352.54 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
test_disable_oobm_ha_state_ineligible | `Error` | 1521.87 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-840785788
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-840689156
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-783998026
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#discussion_r581170130
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -824,11 +824,11 @@ public IPAddressVO doInTransaction(TransactionStatus status) throws Insufficient
if (vlanDbIds == null || vlanDbIds.contains(nonDedicatedVlan.getId()))
nonDedicatedVlanDbIds.add(nonDedicatedVlan.getId());
}
- if (dedicatedVlanDbIds != null && !dedicatedVlanDbIds.isEmpty()) {
+ if (!dedicatedVlanDbIds.isEmpty()) {
fetchFromDedicatedRange = true;
sc.setParameters("vlanId", dedicatedVlanDbIds.toArray());
errorMessage.append(", vlanId id=" + Arrays.toString(dedicatedVlanDbIds.toArray()));
- } else if (nonDedicatedVlanDbIds != null && !nonDedicatedVlanDbIds.isEmpty()) {
Review comment:
yes, you could have told me before i checked it ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-868322933
triggering the tests again to check the latest results.
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-840703963
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-840786313
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-836357653
more conflicts @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-784017476
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-783997612
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#discussion_r581090419
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -824,11 +824,11 @@ public IPAddressVO doInTransaction(TransactionStatus status) throws Insufficient
if (vlanDbIds == null || vlanDbIds.contains(nonDedicatedVlan.getId()))
nonDedicatedVlanDbIds.add(nonDedicatedVlan.getId());
}
- if (dedicatedVlanDbIds != null && !dedicatedVlanDbIds.isEmpty()) {
+ if (!dedicatedVlanDbIds.isEmpty()) {
fetchFromDedicatedRange = true;
sc.setParameters("vlanId", dedicatedVlanDbIds.toArray());
errorMessage.append(", vlanId id=" + Arrays.toString(dedicatedVlanDbIds.toArray()));
- } else if (nonDedicatedVlanDbIds != null && !nonDedicatedVlanDbIds.isEmpty()) {
Review comment:
Null check not needed, the list has been created at line 793.
`List<Long> nonDedicatedVlanDbIds = new ArrayList<Long>();`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-888784092
> @GabrielBrascher I have no opinion to speak of ;
>
> > Additionally, method `com.cloud.network.NetworkModelImpl.areServicesEnabledInZone` does not use list `checkedProvider`; the respective list should either be removed or populated.
> > I have chosen to add provider names at `checkedProvider`, instead of removing it; however, I would appreciate any opinion/suggestion.
>
> However, can you provide insight into your testing, i'm trusting the smoke tests a bit only. Any other testing needed?
@DaanHoogland the `checkedProvider` list is created to be used in order to avoid executing ` isProviderEnabledInPhysicalNetwork(physicalNtwkId, providerName)` multiple times for the same network provider.
However, as it is not populated, the conditional `!checkedProvider.contains(providerName)` will always be true. Therefore that `List` is not usefull and loses its purpose.
For reference, the code:
```
List<String> checkedProvider = new ArrayList<String>();
for (Service service : services) {
// get all the providers, and check if each provider is enabled
List<String> providerNames = _ntwkOfferingSrvcDao.listProvidersForServiceForNetworkOffering(offering.getId(), service);
for (String providerName : providerNames) {
if (!checkedProvider.contains(providerName)) {
result = result && isProviderEnabledInPhysicalNetwork(physicalNtwkId, providerName);
}
checkedProvider.add(providerName);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-840630506
Thanks for the review, @sureshanaparti.
@DaanHoogland I am not sure why the Marving tests are failing. I assume that it is not related to this PR's changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-784221237
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-834416298
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-784017476
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869734356
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-889560761
<b>Trillian test result (tid-1416)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40577 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4714-t1416-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3605.40 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3608.92 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 54.46 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869734356
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-834396626
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#discussion_r658680757
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -1124,15 +1124,18 @@ public boolean applyIpAssociations(Network network, boolean postApplyRules, bool
return success;
}
+ private String generateErrorMessageForOperationOnDisabledZone(String operation, DataCenter zone) {
+ return String.format("Cannot %s, %s is currently disabled.", operation, zone);
+ }
+
@DB
@Override
public AcquirePodIpCmdResponse allocatePodIp(String zoneId, String podId) throws ConcurrentOperationException, ResourceAllocationException {
DataCenter zone = _entityMgr.findByUuid(DataCenter.class, zoneId);
Account caller = CallContext.current().getCallingAccount();
if (Grouping.AllocationState.Disabled == zone.getAllocationState() && !_accountMgr.isRootAdmin(caller.getId())) {
- ResourceAllocationException ex = new ResourceAllocationException("Cannot perform this operation, " + "Zone is currently disabled" + "zoneId=" + zone.getUuid(),
- ResourceType.network);
+ ResourceAllocationException ex = new ResourceAllocationException(generateErrorMessageForOperationOnDisabledZone("allocate Pod IP addresses", zone), ResourceType.network);
Review comment:
very long line :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-834395894
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-839967159
<b>Trillian test result (tid-655)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 123401 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4714-t655-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 55 look OK, 33 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 4.06 | test_accounts.py
test_forceDeleteDomain | `Failure` | 4.00 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.05 | test_accounts.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.44 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.44 | test_iso.py
test_03_1_create_iso_with_checksum_md5_negative | `Error` | 66.47 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.40 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.40 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.41 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.41 | test_iso.py
test_01_create_iso | `Failure` | 1512.18 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3023.16 | test_iso.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_delete_account | `Error` | 1512.15 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.11 | test_network.py
test_deploy_vm_l2network | `Error` | 1.10 | test_network.py
test_l2network_restart | `Error` | 2.17 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.31 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 1.03 | test_network.py
test_reboot_router | `Failure` | 0.04 | test_network.py
test_releaseIP | `Error` | 0.43 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.47 | test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Error` | 1511.78 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1518.36 | test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.11 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_03_ssvm_internals | `Failure` | 3.14 | test_ssvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-881236226
@GabrielBrascher I have no opinion to speak of ;
> Additionally, method `com.cloud.network.NetworkModelImpl.areServicesEnabledInZone` does not use list `checkedProvider`; the respective list should either be removed or populated.
>
> I have chosen to add provider names at `checkedProvider`, instead of removing it; however, I would appreciate any opinion/suggestion.
However, can you provide insight into your testing, i'm trusting the smoke tests a bit only. Any other testing needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-868323262
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-870132097
<b>Trillian test result (tid-1133)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33510 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4714-t1133-kvm-centos7.zip
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869193299
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-869189819
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org