You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2016/12/07 23:45:58 UTC

[jira] [Commented] (SOLR-9839) Use 'useFactory' in tests instead of setting manually

    [ https://issues.apache.org/jira/browse/SOLR-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730331#comment-15730331 ] 

Erick Erickson commented on SOLR-9839:
--------------------------------------

There's also the SystemPropertiesRestoreRule that can be used so you don't have to remember to undo system properties.

useFactory still looks like a good idea, just mentioning the Rule bit for completeness.

> Use 'useFactory' in tests instead of setting manually
> -----------------------------------------------------
>
>                 Key: SOLR-9839
>                 URL: https://issues.apache.org/jira/browse/SOLR-9839
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Mike Drob
>            Priority: Minor
>         Attachments: SOLR-9839.patch
>
>
> We have several tests that will explicitly set a directory factory via SysProp, some of which forget to unset it.
> We should use {{useFactory}} so that we can benefit from the call to {{resetFactory}} in {{SolrTestCaseJ4.teardownTestCases}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org