[GitHub] [accumulo] dlmarion commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005822577


##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
 logger.accumulo.name = org.apache.accumulo
 logger.accumulo.level = debug
 
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)

Review Comment:
   > I don't think we need to reference the issue, because it doesn't really help the user get more information at all about this.
   
   Doesn't it provide more context, for example the possibility that it could be something external to the Accumulo cluster that is just connecting to open ports and sending data?
   
   > Also, I'm not sure we need to have these in here, commented out at all. This is one of many many possible trace logs that the user might be interested in, and I don't think we should comment them all out in the example log4j properties file.
   
   In general, I agree with this. The problem here is that the user has to read the source code to find out all the places where trace logging may be available. I guess the solution here is to just change the root log level to `trace` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org