You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 14:45:21 UTC

[GitHub] [beam] damccorm opened a new issue, #20007: Easy way to run checkJavaLinkage?

damccorm opened a new issue, #20007:
URL: https://github.com/apache/beam/issues/20007

   Follow up of iemejia's comment: [https://github.com/apache/beam/pull/10643#issuecomment-579276082](https://github.com/apache/beam/pull/10643#issuecomment-579276082)
   > I just want some sort of ./gradlew :checkJavaLinkage that works for the whole set of modules of the project. Is this 'feasible' with gradlew **** Beam?
   > 
   > - Considerations
    * Something that can run on Jenkins
    * Comparison with the result of origin/master
    * Simple way to run checkJavaLinkage for all modules
   
   - Options
   ## 1. A shell script that runs checkJavaLinkage
   
   Short-term solution to help iemejia's 31 modules. [https://github.com/apache/beam/pull/10643#issuecomment-578167314](https://github.com/apache/beam/pull/10643#issuecomment-578167314) .
   ## 2. Jenkins plugin
   
   Jenkins seems to have the feature to compare build result with a certain "reference build".
   
   !r2tG83tyDrn.png|width=618,height=389!
   
    
   
   ## 3. LinkageCheckerMain to take ignore exception list
   
   * LinkageCheckerMain to take an option to output JSON file containing linkage errors.
     The file is checked in to Git repository.
   * LinkageCheckerMain to take JSON file to ignore linkage errors
     The class returns non-zero status if there're linkage errors outside the `ignore` file.
     The 
   
   Leveraging the fact that java class name or method name does not contain "`/`", can we use `.git-ignore` syntax to specify linkage errors to ignore?
   
   
   ```
   
   com.google.guava:guava:25.1-jre/com.google.common.collection.ImmutableList/size
   com.google.guava:guava:*/**
   *weld-osgi-bundle*/**
   */com.github.luben.zstd.ZstdInputStream
   */com.github.luben.zstd.ZstdOutputStream
   */org.apache.beam.vendor.bytebuddy.v1_9_3.net.bytebuddy.jar.asm.commons.ModuleHashesAttribute
   
   ```
   
   
   Or XML files to describe more nested structure.
   
   
   
    
   
    
   
   Imported from Jira [BEAM-9206](https://issues.apache.org/jira/browse/BEAM-9206). Original Jira may contain additional context.
   Reported by: suztomo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org