You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2003/03/07 13:23:01 UTC

cvs commit: httpd-2.0/server/mpm config.m4

trawick     2003/03/07 04:23:00

  Modified:    server/mpm config.m4
  Log:
  clean up the invocation of APR_CHECK_APR_DEFINE()...
  it no longer references the second parameter, which was
  incorrectly specified with out-of-tree APR anyway
  (which resulted in prefork being selected on Unix since
  we didn't ever think APR had thread support)
  
  Revision  Changes    Path
  1.47      +1 -1      httpd-2.0/server/mpm/config.m4
  
  Index: config.m4
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/mpm/config.m4,v
  retrieving revision 1.46
  retrieving revision 1.47
  diff -u -r1.46 -r1.47
  --- config.m4	18 Apr 2002 08:16:56 -0000	1.46
  +++ config.m4	7 Mar 2003 12:23:00 -0000	1.47
  @@ -13,7 +13,7 @@
   apache_cv_mpm=$APACHE_MPM
   	
   if test "$apache_cv_mpm" = "worker" -o "$apache_cv_mpm" = "perchild" -o "$apache_cv_mpm" = "leader" -o "$apache_cv_mpm" = "threadpool" ; then
  -  APR_CHECK_APR_DEFINE(APR_HAS_THREADS, srclib/apr)
  +  APR_CHECK_APR_DEFINE(APR_HAS_THREADS)
   
     if test "x$ac_cv_define_APR_HAS_THREADS" = "xno"; then
       AC_MSG_RESULT(The currently selected MPM requires threads which your system seems to lack)
  
  
  

Re: cvs commit: httpd-2.0/server/mpm config.m4

Posted by Jeff Trawick <tr...@attglobal.net>.
William A. Rowe, Jr. wrote:

> At 06:26 AM 3/7/2003, you wrote:
>
> >trawick@apache.org wrote:
> >
> >
> >>trawick     2003/03/07 04:23:00
> >>
> >> Modified:    server/mpm config.m4
> >> Log:
> >> clean up the invocation of APR_CHECK_APR_DEFINE()...
> >
> >
> >if I don't get nailed for the change to APR and this file to make 
> this work better, I'll fix the other such Apache config tests to use 
> APR_CHECK_APR_DEFINE instead of what is used now
>
>
> +1 ... consistency and reuse are generally goodness.

understood, just giving the folks who have been playing in config lately 
a chance to scream^H^H^H^H^H^Hpoint out possible improvements (like Joe 
already did) :)


Re: cvs commit: httpd-2.0/server/mpm config.m4

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 06:26 AM 3/7/2003, you wrote:
>trawick@apache.org wrote:
>
>>trawick     2003/03/07 04:23:00
>>
>>  Modified:    server/mpm config.m4
>>  Log:
>>  clean up the invocation of APR_CHECK_APR_DEFINE()...
>
>
>if I don't get nailed for the change to APR and this file to make this work better, I'll fix the other such Apache config tests to use APR_CHECK_APR_DEFINE instead of what is used now

+1 ... consistency and reuse are generally goodness.



Re: cvs commit: httpd-2.0/server/mpm config.m4

Posted by Jeff Trawick <tr...@attglobal.net>.
trawick@apache.org wrote:

> trawick     2003/03/07 04:23:00
>
>   Modified:    server/mpm config.m4
>   Log:
>   clean up the invocation of APR_CHECK_APR_DEFINE()...


if I don't get nailed for the change to APR and this file to make this 
work better, I'll fix the other such Apache config tests to use 
APR_CHECK_APR_DEFINE instead of what is used now