You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/06 01:31:15 UTC
[GitHub] [arrow-datafusion] jychen7 opened a new pull request, #2166: 7.x: fix clippy
jychen7 opened a new pull request, #2166:
URL: https://github.com/apache/arrow-datafusion/pull/2166
# Which issue does this PR close?
fix clippy
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #2166: 7.x: fix clippy
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #2166:
URL: https://github.com/apache/arrow-datafusion/pull/2166#issuecomment-1090087249
It was forgotten.
```
--> datafusion/tests/merge_fuzz.rs:106:20
|
106 | .iter()
| ____________________^
107 | | .map(|p| p.iter())
108 | | .flatten()
| |______________________^ help: try using `flat_map` instead: `.flat_map(|p| p.iter())`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on pull request #2166: 7.x: fix clippy
Posted by GitBox <gi...@apache.org>.
yjshen commented on PR #2166:
URL: https://github.com/apache/arrow-datafusion/pull/2166#issuecomment-1091021882
Thanks @jychen7!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #2166: 7.x: fix clippy
Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2166:
URL: https://github.com/apache/arrow-datafusion/pull/2166#issuecomment-1090977511
> It was forgotten
hi, my macOS have problem running with `cargo clippy` (similar to https://github.com/rust-lang/rust-clippy/issues/8470), so I just relies on CI for the checking (And CI didn't show all errors at once)
I will mark this PR as "Ready for review" once `clippy` pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #2166: 7.x: fix clippy
Posted by GitBox <gi...@apache.org>.
yjshen merged PR #2166:
URL: https://github.com/apache/arrow-datafusion/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org