You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/19 18:28:54 UTC

[GitHub] [airflow] potiuk commented on issue #17085: Configuration validation for run-configs

potiuk commented on issue #17085:
URL: https://github.com/apache/airflow/issues/17085#issuecomment-882765469


   I think it's a good idea. What kind of validation do you have implemented? I can imagine you could check the structure as well as content of the configuration. I think both could be achieved by simply specifying a jsonschema that the run-config should validate with. We already use jsonschema for a few things in Airflow so we would not even have to add any dependency for that.
   
   Also, if we have the schema we could add the monaco-editor (MIT licenced javascript editor which powers VS code in our UI). It seems to support json-schema for json out-of-the-box, which could give not only validation as-you-type, but also autocompletion: See here https://microsoft.github.io/monaco-editor . 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org