You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/10 20:37:30 UTC

[GitHub] codecov-io commented on issue #5847: [bugfix] fix rows not showing on welcome page

codecov-io commented on issue #5847: [bugfix] fix rows not showing on welcome page
URL: https://github.com/apache/incubator-superset/pull/5847#issuecomment-420052265
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=h1) Report
   > Merging [#5847](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e35bfba308a1ed21226143c18feb4e11f5bec845?src=pr&el=desc) will **decrease** coverage by `9.58%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5847/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5847      +/-   ##
   ==========================================
   - Coverage    63.6%   54.02%   -9.59%     
   ==========================================
     Files         374      328      -46     
     Lines       23321    14018    -9303     
     Branches     2608     2607       -1     
   ==========================================
   - Hits        14833     7573    -7260     
   + Misses       8475     6432    -2043     
     Partials       13       13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/welcome/DashboardTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0Rhc2hib2FyZFRhYmxlLmpzeA==) | `81.81% <100%> (-1.52%)` | :arrow_down: |
   | [superset/connectors/druid/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9fX2luaXRfXy5weQ==) | | |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
   | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | | |
   | [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | | |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | | |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | | |
   | [superset/translations/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | | |
   | ... and [37 more](https://codecov.io/gh/apache/incubator-superset/pull/5847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=footer). Last update [e35bfba...a5e6c90](https://codecov.io/gh/apache/incubator-superset/pull/5847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org