You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/01/05 00:25:48 UTC
Review Request 41900: SQOOP-2772 Sqoop2: Remove the notion of
PrincipalsBean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41900/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2772
https://issues.apache.org/jira/browse/SQOOP-2772
Repository: sqoop-sqoop2
Description
-------
Removed the class as suggested.
Diffs
-----
client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java ca05d1b
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 3109718
common/src/main/java/org/apache/sqoop/json/PrincipalBean.java f89d9ee
common/src/main/java/org/apache/sqoop/json/PrincipalsBean.java d52a462
common/src/test/java/org/apache/sqoop/json/TestPrincipalBean.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 1ed63e4
Diff: https://reviews.apache.org/r/41900/diff/
Testing
-------
Added new unit test for PrincipalBean. Integration tests will be tested by precommit hook.
Thanks,
Jarek Cecho
Re: Review Request 41900: SQOOP-2772 Sqoop2: Remove the notion of
PrincipalsBean
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41900/#review112915
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Fine
On Jan. 4, 2016, 11:25 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41900/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2772
> https://issues.apache.org/jira/browse/SQOOP-2772
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Removed the class as suggested.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java ca05d1b
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 3109718
> common/src/main/java/org/apache/sqoop/json/PrincipalBean.java f89d9ee
> common/src/main/java/org/apache/sqoop/json/PrincipalsBean.java d52a462
> common/src/test/java/org/apache/sqoop/json/TestPrincipalBean.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 1ed63e4
>
> Diff: https://reviews.apache.org/r/41900/diff/
>
>
> Testing
> -------
>
> Added new unit test for PrincipalBean. Integration tests will be tested by precommit hook.
>
>
> Thanks,
>
> Jarek Cecho
>
>