You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/31 01:13:00 UTC

[jira] [Commented] (KAFKA-6499) Avoid creating dummy checkpoint files with no state stores

    [ https://issues.apache.org/jira/browse/KAFKA-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346085#comment-16346085 ] 

ASF GitHub Bot commented on KAFKA-6499:
---------------------------------------

guozhangwang opened a new pull request #4492: KAFKA-6499: Do not write offset checkpoint file with empty offset map
URL: https://github.com/apache/kafka/pull/4492
 
 
   * In Checkpoint.write(), if the offset map passed in is empty, skip the writing of the file which would only contain version number and the empty size. From the reading pov, it is the same as no file existed.
   
   * Add related unit tests.
   
   * Minor fixes on log4j messages.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Avoid creating dummy checkpoint files with no state stores
> ----------------------------------------------------------
>
>                 Key: KAFKA-6499
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6499
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Priority: Major
>
> Today, for a streams task that contains no state stores, its processor state manager would still write a dummy checkpoint file that contains some characters (version, size). This introduces unnecessary disk IOs and should be avoidable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)