You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/28 15:24:13 UTC

[GitHub] [flink] walterddr opened a new pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

walterddr opened a new pull request #11936:
URL: https://github.com/apache/flink/pull/11936


   ## What is the purpose of the change
   
   This PR fixes a LinkageError not captured correctly problem. see: https://github.com/apache/flink/pull/10836/files#r416703366
   
   
   ## Brief change log
   
   Added LinkageError back into the hadoop security module factory
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715",
       "triggerID" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9dd7c29ea400aeef53138c0731bbb5d62ac46588",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=901",
       "triggerID" : "9dd7c29ea400aeef53138c0731bbb5d62ac46588",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9dd7c29ea400aeef53138c0731bbb5d62ac46588 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=901) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a08eef1a61ad744aa4f735d281657d0fcba5308a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162464560) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380) 
   * 1dcd163a3f869576f9504233e152a2e76baef51c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a08eef1a61ad744aa4f735d281657d0fcba5308a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715",
       "triggerID" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7efc5efc190412045358d713b209a691fa2fdad7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a08eef1a61ad744aa4f735d281657d0fcba5308a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162464560) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-621667828


   @walterddr Thanks for the quick fix! It seems the reporter confirmed the fix worked. Could you also try and add a unit test for this?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #11936:
URL: https://github.com/apache/flink/pull/11936#discussion_r420909202



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/security/contexts/LinkageErrorSecurityContextFactory.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.contexts;
+
+import org.apache.flink.runtime.security.SecurityConfiguration;
+import org.apache.flink.runtime.security.SecurityContextInitializeException;
+
+import java.util.concurrent.Callable;
+
+/**
+ * Test security context factory class to test out linkage error circumstances.
+ */
+public class LinkageErrorSecurityContextFactory implements SecurityContextFactory {
+
+	@Override
+	public boolean isCompatibleWith(SecurityConfiguration securityConfig) {
+		return true;
+	}
+
+	@Override
+	public SecurityContext createContext(SecurityConfiguration securityConfig) throws SecurityContextInitializeException {
+		throw new LinkageError("Incompatible due to dependency missing!");
+	}
+
+	/**
+	 * Test security context class.
+	 */
+	public static class TestSecurityContext implements SecurityContext {

Review comment:
       I believe this is not used.

##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/security/contexts/LinkageErrorSecurityContextFactory.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.contexts;
+
+import org.apache.flink.runtime.security.SecurityConfiguration;
+import org.apache.flink.runtime.security.SecurityContextInitializeException;
+
+import java.util.concurrent.Callable;
+
+/**
+ * Test security context factory class to test out linkage error circumstances.
+ */
+public class LinkageErrorSecurityContextFactory implements SecurityContextFactory {

Review comment:
       The test doesn't work because this is not added to the correct `META-INF.services` file. The line where the exception is thrown is never run.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1dcd163a3f869576f9504233e152a2e76baef51c Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/163136724) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a02867a0bce8f1a0174a6a3133b50b76167dbcc9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/163208458) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a08eef1a61ad744aa4f735d281657d0fcba5308a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162464560) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] walterddr commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
walterddr commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-623568748


   @aljoscha could you take another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620677243


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a08eef1a61ad744aa4f735d281657d0fcba5308a (Tue Apr 28 15:26:50 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620677243


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 1892bedeea9fa118b6e3bcb572f63c2e7f6d83e3 (Fri Oct 16 10:35:31 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a02867a0bce8f1a0174a6a3133b50b76167dbcc9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/163208458) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715",
       "triggerID" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9dd7c29ea400aeef53138c0731bbb5d62ac46588",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=901",
       "triggerID" : "9dd7c29ea400aeef53138c0731bbb5d62ac46588",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7efc5efc190412045358d713b209a691fa2fdad7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715) 
   * 9dd7c29ea400aeef53138c0731bbb5d62ac46588 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=901) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-621668232


   And we don't need the `[hotfix]` label since this has a regular Jira Issue associated with it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a02867a0bce8f1a0174a6a3133b50b76167dbcc9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/163208458) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520) 
   * 7efc5efc190412045358d713b209a691fa2fdad7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1dcd163a3f869576f9504233e152a2e76baef51c Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/163136724) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510) 
   * a02867a0bce8f1a0174a6a3133b50b76167dbcc9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/163208458) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] walterddr closed pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
walterddr closed pull request #11936:
URL: https://github.com/apache/flink/pull/11936


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] walterddr commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
walterddr commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-622236613


   > And we don't need the `[hotfix]` label since this has a regular Jira Issue associated with it.
   
   oops.. forgot about that 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] walterddr commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
walterddr commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-622236689


   yes. I would put a test in soon. thanks for noticing. my bad


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715",
       "triggerID" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9dd7c29ea400aeef53138c0731bbb5d62ac46588",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9dd7c29ea400aeef53138c0731bbb5d62ac46588",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7efc5efc190412045358d713b209a691fa2fdad7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715) 
   * 9dd7c29ea400aeef53138c0731bbb5d62ac46588 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a08eef1a61ad744aa4f735d281657d0fcba5308a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162464560) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163208458",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715",
       "triggerID" : "7efc5efc190412045358d713b209a691fa2fdad7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a02867a0bce8f1a0174a6a3133b50b76167dbcc9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/163208458) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=520) 
   * 7efc5efc190412045358d713b209a691fa2fdad7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=715) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] walterddr commented on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
walterddr commented on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-629878641


   thanks @aljoscha for the review. merging


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-620683562


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162464560",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=380",
       "triggerID" : "a08eef1a61ad744aa4f735d281657d0fcba5308a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/163136724",
       "triggerID" : "1dcd163a3f869576f9504233e152a2e76baef51c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a02867a0bce8f1a0174a6a3133b50b76167dbcc9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1dcd163a3f869576f9504233e152a2e76baef51c Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/163136724) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=510) 
   * a02867a0bce8f1a0174a6a3133b50b76167dbcc9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] walterddr removed a comment on pull request #11936: [FLINK-17386][Security][hotfix] fix LinkageError not captured

Posted by GitBox <gi...@apache.org>.
walterddr removed a comment on pull request #11936:
URL: https://github.com/apache/flink/pull/11936#issuecomment-622236613


   > And we don't need the `[hotfix]` label since this has a regular Jira Issue associated with it.
   
   oops.. forgot about that 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org