[jira] Commented: (SHINDIG-487) Fix encoding bugs

["Cassie Doll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628782#action_12628782 ] 

Cassie Doll commented on SHINDIG-487:
-------------------------------------

After trying to get this patch to work for awhile I realized that I think this is doing something we don't want to do. Trying to parse out the encoding proves to be really slow and the gadget rendering code decided not to include it for performance reasons. Instead, they only support non-utf8 encoding if it is set explicitly. 

Because this is what the gadget rendering code does I think the social side should probably do the same. I am going to check in this patch without using the icu4j library.

If we want to discuss adding the library detection in we should probably start a mail thread on list to discuss pros and cons. It should be easy to add in if everyone decides it is a good thing.

> Fix encoding bugs
> -----------------
>
>                 Key: SHINDIG-487
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-487
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (Java)
>         Environment: Windows XP, China as region, Chinese as prefer language
>            Reporter: Jacky Wang
>         Attachments: fix-java-input-encoding-detection-bug.patch, fix-socialapi-post-unicode-bug.patch, fix-socialapi-post-unicode-bug.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> For the input requests, we can't pre-determine its character encoding, thus we need to parse the input according to HttpServletRequest.
> If the HttpServletRequest doesn't have this header, we'll use "UTF-8" as default value.
> For all outbound response, since they're under Shindig's control, we'll set their CharacterEncoding to "UTF-8".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.